Bug 4191 - NSOpenPanel throws argument exception when null passed in, but null is supposed to be valid
Summary: NSOpenPanel throws argument exception when null passed in, but null is suppos...
Status: RESOLVED FIXED
Alias: None
Product: MonoMac
Classification: Desktop
Component: Bindings ()
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-04-02 14:31 UTC by Chris Hamons
Modified: 2012-04-02 15:36 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Chris Hamons 2012-04-02 14:31:58 UTC
I have some code that does:

NSOpenPanel openDialog = new NSOpenPanel;
// setup title, can choosefiles, etc
openDialog.BeginSheet(null, null, null, NSApplication.SharedApplication.MainWindow);

We throw an exception here in MonoMac code:


public virtual void Begin (string directory, string fileName, string[] fileTypes, NSObject modelessDelegate, Selector didEndSelector, IntPtr contextInfo)
{
	if (directory == null)
	{
		throw new ArgumentNullException ("directory");
	}
	if (fileName == null)
	{
		throw new ArgumentNullException ("fileName");
	}
	if (fileTypes == null)
	{
		throw new ArgumentNullException ("fileTypes");
	}
	if (modelessDelegate == null)
	{
		throw new ArgumentNullException ("modelessDelegate");
	}
        ...snip...

According to this if I'm reading it right, this should be valid: https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/ApplicationKit/Classes/NSSavePanel_Class/DeprecationAppendix/AppendixADeprecatedAPI.html#//apple_ref/occ/instm/NSSavePanel/beginSheetForDirectory:file:modalForWindow:modalDelegate:didEndSelector:contextInfo:

I tried using NSNull.Null but couldn't get that to compile.
Comment 1 Duncan Mak 2012-04-02 15:36:06 UTC
Fixed in 6b735a1b.