Bug 4083 - mono-2.10.8.1 metadata\class.c mono_class_setup_vtable_general MonoMethod **vtable; //it is not freed
Summary: mono-2.10.8.1 metadata\class.c mono_class_setup_vtable_general MonoMethod **v...
Status: RESOLVED INVALID
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-03-25 08:27 UTC by kalintchev
Modified: 2012-03-26 00:22 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED INVALID

Description kalintchev 2012-03-25 08:27:57 UTC
mono-2.10.8.1\mono\metadata\class.c
void
mono_class_setup_vtable_general (MonoClass *class, MonoMethod **overrides, int onum, GList *in_setup)

MonoMethod **vtable; 

vtable = alloca (sizeof (gpointer) * max_vtsize);

MonoMethod **tmp = mono_class_alloc0 (class, sizeof (gpointer) * class->vtable_size);
memcpy (tmp, vtable,  sizeof (gpointer) * class->vtable_size);
mono_memory_barrier ();
class->vtable = tmp;

//It looks like there is a memory leak here. The vtable memory is not freed.
for (i = 0; i < max_vtsize; i++) g_free(vtable[i]);
Comment 1 kalintchev 2012-03-25 08:37:31 UTC
for (i = 0; i < max_vtsize; i++) g_free(vtable[i]); //is not correct
g_free(vtable);
Comment 2 Zoltan Varga 2012-03-26 00:22:44 UTC
No, there isn't. 'vtable' is allocated on the stack, and its entries don't need to be freed.