Bug 40360 - CreateAppBundleDependsOn differs from Xamarin.iOS regarding AppBundleDir
Summary: CreateAppBundleDependsOn differs from Xamarin.iOS regarding AppBundleDir
Status: RESOLVED FIXED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: MSBuild ()
Version: 2.8.0 (C7)
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Jeffrey Stedfast
URL:
Depends on:
Blocks:
 
Reported: 2016-04-13 19:38 UTC by Aaron Bockover [MSFT]
Modified: 2016-04-13 20:15 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Aaron Bockover [MSFT] 2016-04-13 19:38:08 UTC
In Xamarin.iOS, AppBundleDir is defined differently such that I can override <CreateAppBundleDependsOn> and AppBundleDir will have already been set.

In Xamarin.Mac, its definition of <CreateAppBundleDependsOn> actually depends on _GenerateBundleName, meaning that AppBundleDir will not have been defined yet.

Example, in Xamarin.iOS, I can do:

  <Target Name="_MyAppBundleTarget">
    <Message Text="$(AppBundleDir)" />
  </Target>
  <PropertyGroup>
    <CreateAppBundleDependsOn>
      _MyAppBundleTarget;
      $(CreateAppBundleDependsOn)
    </CreateAppBundleDependsOn>
  </PropertyGroup>

And the correct AppBundleDir will be output. However on Xamarin.Mac, it has not yet been defined...

As a workaround, I need to switch the order of the dependencies in my override of <CreateAppBundleDependsOn> or call the "private" target _GenerateBundleName myself.

It would be great to have consistency here so custom targets can be more easily shared between iOS and Mac.
Comment 1 Jeffrey Stedfast 2016-04-13 20:15:14 UTC
Fixed in master