Bug 39112 - 4.3.2 Alpha cannot compile on s390x because MONO_ARCH_AOT_SUPPORTED is missing for one call of get_pinvoke_import
Summary: 4.3.2 Alpha cannot compile on s390x because MONO_ARCH_AOT_SUPPORTED is missin...
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: PC Linux
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-02-25 07:37 UTC by Timotheus Pokorra
Modified: 2016-02-28 14:37 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Timotheus Pokorra 2016-02-25 07:37:22 UTC
I get this error when compiling for s390x:

aot-compiler.c: In function 'mono_aot_get_direct_call_symbol':
aot-compiler.c:7739:11: error: implicit declaration of function 'get_pinvoke_import' [-Werror=implicit-function-declaration]
     sym = get_pinvoke_import (llvm_acfg, method);
           ^~~~~~~~~~~~~~~~~~

I checked the code at https://github.com/mono/mono/blob/ba2e5e42f342f2b64fedc3cee2ef925c57c4a325/mono/mini/aot-compiler.c#L7739
and noticed that the function get_pinvoke_import is defined in line 4734 inside an ifdef MONO_ARCH_AOT_SUPPORTED, but in line 7739 that ifdef is missing.
Comment 1 Zoltan Varga 2016-02-28 14:37:33 UTC
Fixed by 9a8067719ced08ebd866013637db865f74774d2d on the mono-4.4.0-branch.