Bug 3893 - ILGenerator.Emit newobj argument validation
Summary: ILGenerator.Emit newobj argument validation
Status: RESOLVED NOT_ON_ROADMAP
Alias: None
Product: Class Libraries
Classification: Mono
Component: mscorlib ()
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-03-13 18:46 UTC by Mikayla Hutchinson [MSFT]
Modified: 2016-02-25 14:22 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED NOT_ON_ROADMAP

Description Mikayla Hutchinson [MSFT] 2012-03-13 18:46:16 UTC
ILGenerator.Emit (OpCodes.NewObj, arg) doesn't validate that arg is a ConstructorInfo. Passing in a Type instead results in a cryptic TypeLoadException when compiling the method, with no useful clues about the reason.
Comment 1 marcos.henrich 2016-02-25 14:22:24 UTC
As per the msdn docs ILGenerator.Emit (OpCode, Type), creates IL code with the specified opcode followed by a token of the given type, and it only throws an exception when the given type is null.

Currently mono, .NET, and CoreFX ILGenerator.Emit methods doesn't perform any kind of validation between opcodes and arguments used.

There are 17 overloads of ILGenerator.Emit and dozens of opcodes, validating all the possible combinations is not on the road map.