Bug 38535 - Minimum height is ignored on button in Android
Summary: Minimum height is ignored on button in Android
Status: CONFIRMED
Alias: None
Product: Forms
Classification: Xamarin
Component: Android ()
Version: 2.0.0
Hardware: PC Mac OS
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2016-02-08 13:28 UTC by Andrei L.
Modified: 2016-12-20 23:14 UTC (History)
2 users (show)

Tags: ac
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 38535 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Andrei L. 2016-02-08 13:28:11 UTC
ButtonRenderer is ignoring the minimum height set on a native button when calculating Height.

In renderer I have 

        protected override void OnElementChanged(ElementChangedEventArgs<Button> e)
        {
            base.OnElementChanged(e);
            if (e.NewElement != null)
            {
                var nativeButton = this.Control;
                nativeButton.SetMinimumHeight(0);
            }
        }

I am checking the Minimum Height before setting it to 0 and it is 96.

I added an override 

        public override SizeRequest GetDesiredSize(int widthConstraint, int heightConstraint) 

and the Height request returned by `base.GetDesiredSize` is still 96 and the Text is not that big to fill that space, actually it takes about 1/3 of the button Height
Comment 1 adrianknight89 2016-09-27 11:23:47 UTC
See https://github.com/xamarin/Xamarin.Forms/pull/386