Bug 3823 - [Git] Submodules always show up as modified
Summary: [Git] Submodules always show up as modified
Status: RESOLVED NORESPONSE
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Version Control ()
Version: Trunk
Hardware: PC Mac OS
: Low normal
Target Milestone: ---
Assignee: Alan McGovern
URL:
Depends on:
Blocks:
 
Reported: 2012-03-09 10:17 UTC by Alan McGovern
Modified: 2013-12-05 18:48 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED NORESPONSE

Description Alan McGovern 2012-03-09 10:17:28 UTC
NGit has a bug where the 'Length' of a submodule as stored in the git repository is different to the 'Length' of the submodule on disk. As such, it always shows up as modified if you do a 'Review Status' call.

The issue is in WorkingTreeIter.CompareMetadata where the following call fails:

if (!entry.IsSmudged && (GetEntryLength() != entry.Length))

There is no readily apparent way for me to fix this. I believe NGit should probably be altered to ignore submodules when doing a git status, similar to what git does.
Comment 1 Lluis Sanchez 2013-06-27 06:08:17 UTC
*** Bug 10577 has been marked as a duplicate of this bug. ***
Comment 2 Marius Ungureanu 2013-07-16 14:29:24 UTC
This is no longer an issue from what I noticed.
Comment 3 Andres G. Aragoneses 2013-07-16 18:26:47 UTC
I still can reproduce this bug (at least with the steps to reproduce explained in the duped bug 10577).
Comment 4 Marius Ungureanu 2013-07-16 18:53:45 UTC
A fix for this has been issued in master for MD. Submodules are automatically init-ed on a repository clone.
Comment 5 Andres G. Aragoneses 2013-07-16 19:09:38 UTC
When I wrote comment#3, I was referring to master.

Bug 10577 is not about the scenario when the user does a clone with MonoDevelop, but a manual clone.
Comment 6 PJ 2013-11-19 17:04:16 UTC
This bug has been in the NEEDINFO state with no changes for the last 90 days. Can we put this back into the NEW or CONFIRMED state, or are we still awaiting response?

If there is no change in the status of this bug over the next two weeks, this bug will be marked as NORESPONSE.
Comment 7 Andres G. Aragoneses 2013-11-19 20:24:21 UTC
I think you can put this back to NEW|CONFIRMED.
Comment 8 PJ 2013-12-05 18:34:17 UTC
This bug has not been changed from the NEEDINFO state since my previous comment, marking as RESOLVED NORESPONSE.

Please feel free to REOPEN this bug at any time if you are still experiencing the issue. Please add the requested information and set the bug back to the NEW (or CONFIRMED) state.
Comment 9 Andres G. Aragoneses 2013-12-05 18:48:38 UTC
>This bug has not been changed from the NEEDINFO state since my previous
>comment, marking as RESOLVED NORESPONSE.

Well, I don't have permissions to change the state, otherwise I would have changed it. PJ: did you at least read my comment #7?

>Please feel free to REOPEN this bug at any time if you are still experiencing
>the issue. Please add the requested information and set the bug back to the NEW
>(or CONFIRMED) state.

As I don't have permissions to REOPEN this bug, then I've just REOPENED bug 10577 FYI.