Bug 3795 - Git addin crashes MD on Windows
Summary: Git addin crashes MD on Windows
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Version Control ()
Version: Trunk
Hardware: PC Windows
: --- major
Target Milestone: ---
Assignee: Alan McGovern
URL:
Depends on:
Blocks:
 
Reported: 2012-03-07 16:32 UTC by Mikayla Hutchinson [MSFT]
Modified: 2012-03-08 05:17 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2012-03-07 16:32:42 UTC
Reproducible opening MD solution on Windows.

System.ArgumentNullException: Value cannot be null.
Parameter name: value
   at System.Boolean.Parse(String value)
   at NGit.Util.FS.ReadPipe(FilePath dir, String[] command, String encoding) in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Util\FS.cs:line 313
   at NGit.Util.FS_Win32.DiscoverGitPrefix() in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Util\FS_Win32.cs:line 117
   at NGit.Util.FS.GitPrefix() in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Util\FS.cs:line 463
   at NGit.Util.SystemReader._SystemReader_69.OpenSystemConfig(Config parent, FS fs) in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Util\SystemReader.cs:line 85
   at NGit.Storage.File.FileRepository..ctor(BaseRepositoryBuilder options) in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Storage.File\FileRepository.cs:line 142
   at NGit.Storage.File.FileRepository..ctor(FilePath gitDir) in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Storage.File\FileRepository.cs:line 113

   at NGit.Storage.File.FileRepository..ctor(String gitDir) in c:\Users\Michael\work\monodevelop\main\contrib\NGit\NGit.Storage.File\FileRepository.cs:line 129
   at MonoDevelop.VersionControl.Git.LocalGitRepository..ctor(String path) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitRepository.cs:line 1488
   at MonoDevelop.VersionControl.Git.GitRepository..ctor(FilePath path, String url) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitRepository.cs:line 71
   at MonoDevelop.VersionControl.Git.GitVersionControl.GetRepositoryReference(FilePath path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitVersionControl.cs:line 61
   at MonoDevelop.VersionControl.Git.GitVersionControl.GetRepositoryReference(FilePath path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitVersionControl.cs:line 65
   at MonoDevelop.VersionControl.Git.GitVersionControl.GetRepositoryReference(FilePath path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitVersionControl.cs:line 65
   at MonoDevelop.VersionControl.Git.GitVersionControl.GetRepositoryReference(FilePath path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitVersionControl.cs:line 65
   at MonoDevelop.VersionControl.Git.GitVersionControl.GetRepositoryReference(FilePath path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl.Git\MonoDevelop.VersionControl.Git\GitVersionControl.cs:line 65
   at MonoDevelop.VersionControl.VersionControlService.GetRepositoryReference(String path, String id) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl\MonoDevelop.VersionControl\VersionControlService.cs:line 199
   at MonoDevelop.VersionControl.VersionControlService.GetRepository(IWorkspaceObject entry) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl\MonoDevelop.VersionControl\VersionControlService.cs:line 185
   at MonoDevelop.VersionControl.Views.SubviewAttachmentHandler.HandleDocumentChanged(Object sender, EventArgs e) in c:\Users\Michael\work\monodevelop\main\src\addins\VersionControl\MonoDevelop.VersionControl\MonoDevelop.VersionControl.Views\SubviewAttachmentHandler.cs:line 48
   at System.EventHandler.Invoke(Object sender, EventArgs e)
   at MonoDevelop.Ide.Gui.Workbench.OnDocumentChanged(Object s, EventArgs a) in c:\Users\Michael\work\monodevelop\main\src\core\MonoDevelop.Ide\MonoDevelop.Ide.Gui\Workbench.cs:line 594
   at MonoDevelop.Ide.Gui.DefaultWorkbench.OnActiveWindowChanged(Object sender, EventArgs e) in c:\Users\Michael\work\monodevelop\main\src\core\MonoDevelop.Ide\MonoDevelop.Ide.Gui\DefaultWorkbench.cs:line 749
   at Gtk.Notebook.SwitchPageSignalCallback(IntPtr arg0, IntPtr arg1, UInt32 arg2, IntPtr gch)
Comment 1 Alan McGovern 2012-03-08 05:17:31 UTC
Fixed, just had to set a default value for a boolean property.

I am just checking NGit out from github and am going to run the unit tests on windows. They would've caught this issue if they had been run.