Bug 37444 - Locking on generic type parameter results in compiler error
Summary: Locking on generic type parameter results in compiler error
Status: RESOLVED FEATURE
Alias: None
Product: Compilers
Classification: Mono
Component: C# ()
Version: 4.0.0
Hardware: PC Linux
: --- normal
Target Milestone: ---
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2016-01-06 12:07 UTC by Tomasz Malinowski
Modified: 2016-08-01 15:37 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
sample code (375 bytes, text/plain)
2016-01-06 12:07 UTC, Tomasz Malinowski
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FEATURE

Description Tomasz Malinowski 2016-01-06 12:07:06 UTC
Created attachment 14465 [details]
sample code

Locking on non-constrained generic type parameter results in the following compiler error: "`TKey' is not a reference type as required by the lock statement (CS0185)" (see attached code sample).

This seems to actually be The Right Thing (see https://msdn.microsoft.com/en-us/library/aa479858.aspx#bestpractices_topic6), but Microsoft compiler raises neither error nor warning in this situation, leading to some code failing to build on Mono despite building on .NET.
Comment 1 Marek Safar 2016-01-11 12:52:31 UTC
The spec is not very strict here (yet) but I think we are doing right think. I'll see if the wording can be fixes to disallow this explicitly.
Comment 2 Marek Safar 2016-08-01 15:37:55 UTC
The spec forbids this code so csc just violates the spec and we won't follow in this case as it does not make sense to mis-compile this code.