Bug 36329 - Codesign tasks should sign frameworks
Summary: Codesign tasks should sign frameworks
Status: RESOLVED FIXED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: MSBuild ()
Version: Master
Hardware: PC Mac OS
: High normal
Target Milestone: 2.8.0 (C7)
Assignee: Chris Hamons
URL:
Depends on:
Blocks:
 
Reported: 2015-11-28 15:55 UTC by Aaron Bockover [MSFT]
Modified: 2015-12-15 16:22 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Aaron Bockover [MSFT] 2015-11-28 15:55:39 UTC
Our Codesign task signs native libraries within and the while app bundle, but it does not sign bundled frameworks.

Conservatorio bundles the Sparkle app update framework, and has to extend MSBuild to codesign it [1]:

  <Target Name="CodesignSparkleFramework" BeforeTargets="_CodesignAppBundle">
    <Exec Command="codesign -v --force --sign &quot;$(CodeSigningKey)&quot; &quot;$(AppBundleDir)/Contents/Frameworks/Sparkle.framework&quot;" />
  </Target>

This is suboptimal for two reasons:

  1. this should be handled automatically
  2. it depends on _CodesignAppBundle, which is considered a 'private' API due to the _ prefix, so future XM releases may break it

[1] https://github.com/abock/conservatorio/blob/master/Conservatorio.Mac/Conservatorio.Mac.csproj#L134
Comment 1 Rolf Bjarne Kvinge [MSFT] 2015-11-30 09:35:26 UTC
XI codesigns frameworks now, so maybe this logic can be shared somehow.
Comment 2 Rolf Bjarne Kvinge [MSFT] 2015-11-30 09:36:19 UTC
XI supports embedding frameworks using the same logic as for binding projects, so this should be trivial to implement (and share implementation too).
Comment 4 Chris Hamons 2015-12-15 16:22:39 UTC
This should be fixed with LinkWith support (now in master). You still have to hack your binding project to copy in the framework, but that is the same for XI right now. 

https://developer.xamarin.com/guides/ios/advanced_topics/embedded_frameworks/