Bug 35893 - Resource.Designer.cs Generated Constants
Summary: Resource.Designer.cs Generated Constants
Status: CONFIRMED
Alias: None
Product: Android
Classification: Xamarin
Component: Designer ()
Version: 7.3 (15.2)
Hardware: Macintosh Mac OS
: --- normal
Target Milestone: ---
Assignee: Jérémie Laval
URL:
Depends on:
Blocks:
 
Reported: 2015-11-16 11:42 UTC by Caleb Morris
Modified: 2017-07-06 08:13 UTC (History)
6 users (show)

Tags: BZCU
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 35893 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Caleb Morris 2015-11-16 11:42:01 UTC
I've started using Gendarme (mono-tools) for some static analysis to improve my project code with Xamarin and noticed that the generated code in the Android Resource.Designer.cs is using a bad practice by making all the generated values `public const int`.

The rule that marks it as a bad practice is Gendarme.Rules.BadPractice.AvoidVisibleConstantFieldRule.


Possible solutions:
- Change the access to internal (`internal const int`) to prevent external assemblies from accessing
- Change to `public static readonly` as Gendarme suggests so the assemblies that reference a value don't have to rebuild on changes.
- Add a accessor level option to an android project/designer file.
Comment 1 Prashant [MSFT] 2017-07-06 08:13:44 UTC
The best practices are subjective. 
I am not sure if it is by design that values in designer files are `public const`, I will request engineering team to comment on this.