Bug 34525 - calli with generic signature fails (not inflated)
Summary: calli with generic signature fails (not inflated)
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: All All
: Normal normal
Target Milestone: (C7)
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-10-02 11:17 UTC by Virgile Bello
Modified: 2017-08-28 15:05 UTC (History)
8 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Sample Created (33.00 KB, application/zip)
2015-10-28 10:26 UTC, Rajneesh Kumar
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Virgile Bello 2015-10-02 11:17:39 UTC
https://github.com/mono/mono/pull/2103

calli with generic signature was not properly infalted.
Created a pull request with fix.

I made this issue to follow status/ETA for this fix in both Xamarin Android and iOS.
Comment 1 João Matos 2015-10-02 11:22:40 UTC
Thanks, it's too late for this fix to land in our upcoming Cycle 6 release but I've backported it to the relevant branches and it should end up in Cycle 6 Service Release 1.
Comment 2 PJ 2015-10-23 14:11:12 UTC
This was special-cased by Miguel for inclusion in C6.
Comment 3 Virgile Bello 2015-10-24 01:18:25 UTC
Thanks!
Comment 4 Rajneesh Kumar 2015-10-28 10:26:18 UTC
Created attachment 13558 [details]
Sample Created

To verify this issue I tried to reproduce this but not able to reproduce this. As per my understanding to reproduce this issue I have crested the sample application that uses a Generic method, that is called on button click event. But I am able to build and run the application successfully.

Screencast: http://www.screencast.com/t/PV6MsafChpUG

@Virgile I am not sure about the proper steps to reproduce this issue, could you please have a look on the attached test sample and let me the proper steps and expected result to reproduce this issue. So that we can verify this issue efficiently at our end.

Thanks..!

Environment Info:

=== Xamarin Studio ===

Version 5.9.7 (build 22)
Installation UUID: 229ec167-a154-47bf-bb8b-10fe36c1ad41
Runtime:
	Mono 4.0.4 ((detached/d481017)
	GTK+ 2.24.23 (Raleigh theme)

	Package version: 400040004

=== Apple Developer Tools ===

Xcode 6.2 (6776)
Build 6C131e

=== Xamarin.Android ===

Version: 5.1.8.0 (Enterprise Edition)
Android SDK: /Users/360_macmini/Library/Developer/Xamarin/android-sdk-macosx
	Supported Android versions:
		4.0.3  (API level 15)
		4.4    (API level 19)
		4.4.87 (API level 20)
		5.0    (API level 21)
		6.0    (API level 23)
Java SDK: /usr
java version "1.7.0_71"
Java(TM) SE Runtime Environment (build 1.7.0_71-b14)
Java HotSpot(TM) 64-Bit Server VM (build 24.71-b01, mixed mode)

=== Xamarin Android Player ===

Version: Unknown version
Location: /Applications/Xamarin Android Player.app

=== Xamarin.iOS ===

Version: 9.0.1.29 (Enterprise Edition)
Hash: 1d27ac2
Branch: master
Build date: 2015-09-25 18:08:44-0400

=== Xamarin.Mac ===

Version: 2.0.2.111 (Enterprise Edition)

=== Build Information ===

Release ID: 509070022
Git revision: 6bd1f169df44ca96addf8a035316c535a4fa46fa
Build date: 2015-09-30 12:30:15-04
Xamarin addins: 1c3e5c0859bdfec0ecd481a57ad6c03bc22f5536

=== Operating System ===

Mac OS X 10.9.5
Darwin 360-MACMINIs-Mac-mini.local 13.4.0 Darwin Kernel Version 13.4.0
    Sun Aug 17 19:50:11 PDT 2014
    root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64
Comment 5 Virgile Bello 2015-11-06 02:39:07 UTC
Still having the issue with latest Xamarin alpha (not sure if it was supposed to be part of C6 or C6 SR1).

Also I noticed the fix is part of Mono 4.3 branch but not 4.2. Is C6 using 4.2 as is (in which case it should be cherry-picked), or a custom branch that includes this fix?

@Rajneesh Kumar: You won't be able to reproduce it with normal code. The PR includes a Mono unit test to easily reproduce it though.
Comment 6 PJ 2015-11-06 10:13:57 UTC
Hi Virgile,

Unfortunately it is once again not slated for baseline, comments from Kumpera:

> On 4.0, the behavior would be a runtime crash.
> On master, the correct behavior happens, which is to print a number.
> Looks like there are further fixes required here (I think I know which one) to make this work on 4.2.
> Given this is not a regression and affects a pretty small corner case, let's move this issue to SR1.

Moving to C6SR1.
Comment 7 Virgile Bello 2015-11-09 21:20:49 UTC
Thanks.

For C6SR1, are we talking about days? Months?

This is actually quite a huge blocker for our product (Paradox Engine) as it is required for the animation system.
Comment 8 Rodrigo Kumpera 2015-11-17 01:18:25 UTC
It's before EOY.
Comment 9 Peter Collins 2015-12-16 18:07:14 UTC
We've since frozen for C6SR1 and it appears that again this unfortunately is not included. Moving to the C6SR2 milestone.
Comment 10 Virgile Bello 2016-01-14 05:56:37 UTC
Thanks for the update.

FYI, we spent lot of time adding workaround, and they are ugly (we have to manually expand generic instantiations ourselves...).
Would be happy to get rid of those special cases.
Comment 11 Virgile Bello 2016-01-14 05:57:15 UTC
(we rely on this for the animation/update system in Xenko Game Engine)
Comment 12 PJ 2016-03-02 20:09:09 UTC
This is also not going to make it into C6SR2, as the scope of that release has been reduced. The PR is in master and will therefore make it into C7, so updating milestone.

Since the PR in comment 0 resolves the issue, marking as RESOLVED.