Bug 32858 - ListView.RefreshCommand and ReactiveUI.ReactiveCommand confilct
Summary: ListView.RefreshCommand and ReactiveUI.ReactiveCommand confilct
Status: RESOLVED ANSWERED
Alias: None
Product: Forms
Classification: Xamarin
Component: iOS ()
Version: 1.4.4
Hardware: Macintosh Mac OS
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-08-07 07:43 UTC by outring
Modified: 2017-03-08 16:37 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED ANSWERED

Description outring 2015-08-07 07:43:45 UTC
The same ReactiveCommand can't be executed during execution, so when it starts execution it raises ICommand.CanExecuteChanged and ReactiveCommand.CanExecute() will return false.
If ReactiveCommand is set to ListView.RefreshCommand and when it executes it sets ListView.IsPullToRefreshEnabled to false internally, which removes UIRefreshControl without calling UIRefreshControl.EndRefreshing().

It would be better not to change IsPullToRefreshEnabled until IsRefreshing is set to false. See also 32857
Comment 1 John Miller [MSFT] 2016-07-01 19:19:56 UTC
I've filed a new bug which is similar to what you are talking about except it's not specific to ReactiveCommand: https://bugzilla.xamarin.com/show_bug.cgi?id=42330

Also, it does appear the code is calling EndRefreshing (see my notes in #42330). I also expect a different outcome then you mentioned and believe that the control should not be removed based on CanExecute.
Comment 2 Paul DiPietro [MSFT] 2017-03-08 16:37:43 UTC
For purposes of upkeep I'm going to close this and defer to 42330 since it includes a reproduction and more information to reference while still referring to ReactiveCommand.