Bug 32841 - GKRandomDistribution.FromLowestValue(int,int) might be better renamed .Between or .FromLowAndHighValues or ...
Summary: GKRandomDistribution.FromLowestValue(int,int) might be better renamed .Betwee...
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 8.99 (iOS9 previews)
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2015-08-06 18:10 UTC by Larry O'Brien
Modified: 2015-08-07 11:16 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Larry O'Brien 2015-08-06 18:10:40 UTC
I know it's not our standard, but binding distributionWithLowestValue:highestValue: to "FromLowestValue" is, I think, confusing.
Comment 1 Sebastien Pouliot 2015-08-06 20:43:00 UTC
Agreed - any selector with a `With` [1] is generally best shortened (because the first parameter can be inferred from the signature and the later ones would be absent).

Now to find a better name... what about ? (open to other suggestions)

GKRandomDistribution GetValueBetween (nint lowestInclusive, nint highestInclusive);


[1] FromDieWithSideCount is (differently) bad because the method name and parameter both says the same thing - I'll change that one too
Comment 2 Sebastien Pouliot 2015-08-06 20:45:05 UTC
not a value... maybe more 

> GKRandomDistribution GetDistributionBetween (nint lowestInclusive, nint
highestInclusive);
 
and 

> GKRandomDistribution GetDie (nint sideCount);

as all other methods are already prefixed by `Get`.
Comment 3 Sebastien Pouliot 2015-08-07 11:16:17 UTC
Fixed in maccore/xcode7 5c2de6c6cbc0eaa97a0379f1da413996f721eb4f