Bug 32187 - NSWindow.EndSheet api binding not using NSModalResponse enum
Summary: NSWindow.EndSheet api binding not using NSModalResponse enum
Status: RESOLVED FIXED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Library (Xamarin.Mac.dll) ()
Version: 2.0.0
Hardware: Macintosh Mac OS
: Normal enhancement
Target Milestone: 15.3
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2015-07-21 06:48 UTC by Sjoerd van Noort
Modified: 2017-05-17 19:00 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Sjoerd van Noort 2015-07-21 06:48:02 UTC
NSWindow.EndSheet(NSWindow sheetWindow, nint returnCode)

Should be

NSWindow.EndSheet(NSWindow sheetWindow, NSModalResponse returnCode)

NSModalResponse enum is defined and should be used according to apple docs.

Workaround I currently use for the second argument (in this example Cancel code):
new nint((long) NSModalResponse.Cancel)
Comment 1 Chris Hamons 2016-07-19 21:11:40 UTC
We unfortunately can not fix this until the next time we do an API break.
Comment 2 Sebastien Pouliot 2017-05-17 03:16:29 UTC
This can be fixed without a breaking change.

PR https://github.com/xamarin/xamarin-macios/pull/2100