Bug 3210 - FileService purpose should be clearer
Summary: FileService purpose should be clearer
Status: CONFIRMED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Shell ()
Version: Trunk
Hardware: PC Mac OS
: Lowest enhancement
Target Milestone: master
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2012-02-02 17:01 UTC by Mikayla Hutchinson [MSFT]
Modified: 2016-11-05 00:10 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 3210 on Developer Community or GitHub if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: Developer Community HTML or GitHub Markdown
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
CONFIRMED

Description Mikayla Hutchinson [MSFT] 2012-02-02 17:01:47 UTC
Currently the FIleService's purpose is not very clear.

There are methods to broadcast file change events, and methods that duplicate System.IO functionality (e.g. delete, move) but broadcast change events. These only need to be called when the VCS or project system needs to be aware of the change. Calling them in other cases is just wasting cycles.

There are some other methods for things like creating temp directories or performing atomic renames which do not broadcast events.

We need to separate them out into more clearly named classes - maybe something like ProjectFileService and FileSystemUtility - so that they're less likely to be misused.
Comment 1 Jeffrey Stedfast 2012-02-02 17:17:21 UTC
yea, sounds like a good idea
Comment 2 Marius Ungureanu 2016-11-05 00:10:27 UTC
Marking as confirmed, the issue still exists.