Bug 31444 - MSBuild accepts unquoted strings, should xbuild ?
Summary: MSBuild accepts unquoted strings, should xbuild ?
Status: NEW
Alias: None
Product: Tools
Classification: Mono
Component: xbuild ()
Version: unspecified
Hardware: PC Other
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-06-28 05:58 UTC by Marcin Cieślak
Modified: 2015-06-28 07:05 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 31444 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Marcin Cieślak 2015-06-28 05:58:19 UTC
this works under MSBuild:

      Condition="!Exists($(NuGetToolPath))"

but fails on xbuild.

This works on both:

      Condition="!Exists('$(NuGetToolPath)')"

also https://github.com/dotnet/corefx/pull/286#issue-52395215 suggests xbuild's behaviour is correct
according to MSDN.

Should we accept MSBuild's treatment of bare variables?
Comment 1 Alexander Köplinger 2015-06-28 07:05:14 UTC
If it doesn't make xbuild's parsing logic unnecessarily complex it'd be good to behave the same as MSBuild. Otherwise, I personally don't see a compelling reason since it can be easily fixed in the source script to match with MSDNs spec.