Bug 29199 - [WinRT] PageRenderer.OnElementChanged is not virtual
Summary: [WinRT] PageRenderer.OnElementChanged is not virtual
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.4.2
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-04-17 11:24 UTC by Michael Rumpler
Modified: 2015-06-30 06:07 UTC (History)
5 users (show)

Tags: windows, ac
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Michael Rumpler 2015-04-17 11:24:15 UTC
In Xamarin.Forms.Platform.WinRT.dll, version 1.4.2.6353-pre2 the method Xamarin.Forms.Platform.WinRT.PageRenderer.OnElementChanged is not virtual. Therefore custom renderers cannot override it.

Furthermore the method OnElementPropertyChanged is missing. This method should also be virtual in all renderers.
Comment 1 Ram Chandra 2015-05-26 06:58:18 UTC
I have checked this issue and observed that the method Xamarin.Forms.Platform.WinRT.PageRenderer.OnElementChanged is virtual Like "protected virtual void OnElementChanged".

Screencast: http://www.screencast.com/t/lkBE6s1F

Could you please provide me few steps? so that I can reproduce it at our end.
Comment 2 Michael Rumpler 2015-05-26 07:33:57 UTC
It has been fixed in the meantime (with 1.4.3-pre1 I believe). You can close this bug.

OnElementPropertyChanged is still missing. But this is the case in many renderers also for other platforms, so I don't think that it will be changed.