Bug 26917 - REGRESSION: HasUnEvenRows in 1.3.3.6318-pre1
Summary: REGRESSION: HasUnEvenRows in 1.3.3.6318-pre1
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.3.3
Hardware: PC Windows
: Normal normal
Target Milestone: 1.3.4
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-02-10 12:30 UTC by Ian
Modified: 2015-02-16 04:59 UTC (History)
6 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Ian 2015-02-10 12:30:36 UTC
Upgrading to 1.3.3.6318-pre1 on iOS causes the ListView.HasUnEvenRows to not be obeyed. Worked in earlier versions

Here's the Cell I use:

    public class MenuCell : ViewCell
    {
        public MenuCell()
        {
            //Create the UI for the cells
            var lblTitle = new Label
            {
                XAlign = TextAlignment.Start,
                YAlign = TextAlignment.Center,
                TextColor = Kulers.MenuTextColor,
                HorizontalOptions = LayoutOptions.Start,
                VerticalOptions = LayoutOptions.CenterAndExpand,
                FontSize = Device.GetNamedSize(NamedSize.Medium, typeof(Label)),
            };

            Height = 60;
            
            var imgIcon = new Image()
            {
                Aspect = Aspect.AspectFit,
                HeightRequest = 25,
                WidthRequest = 25
            };

            var stack = new StackLayout
            {
                Orientation = StackOrientation.Horizontal,
                Padding = new Thickness(Device.OnPlatform(5, 15, 0), 0, 0, 0)  ,
                BackgroundColor = Kulers.MenuBackgroundColor ,
                HorizontalOptions = LayoutOptions.Start,
                VerticalOptions = LayoutOptions.CenterAndExpand
            };

            stack.Children.Add(imgIcon);
            stack.Children.Add(lblTitle);
 
            

            lblTitle.SetBinding(Label.TextProperty, BaseViewModel.TitlePropertyName);
            imgIcon.SetBinding(Image.SourceProperty, MenuItem.IconSourcePropertyName );

            View = stack;
         }
        }
Comment 1 Sadik Ali 2015-02-11 01:28:38 UTC
I have checked this issue and able to reproduce this issue with the help of Sample project : http://developer.xamarin.com/samples/WorkingWithListview/
 and here are my observation:

As per bug descritpion I am getting issue with Xamarin.Forms.1.3.1.6294-pre1 as shown in screencast: http://www.screencast.com/t/xJGF9k1Z

I observed that its working fine with Xamarin.Forms.1.3.4.6328-pre2 as shown in screencast : http://www.screencast.com/t/wRoZyh0y9  .

Can you please check it with Xamarin.Forms.1.3.4.6328-pre2 ? Also let us know if you are facing this issue again.

Environment Info:
Xamarin.Forms.1.3.1.6294-pre1
Xamarin.Forms.1.3.4.6328-pre2
Xamarin.ios 8.6.0.51 
Build Host : 3.9.0.234

Microsoft Visual Studio Professional 2013
Version 12.0.31101.00 Update 4
Microsoft .NET Framework
Version 4.5.51641

Installed Version: Professional

Xamarin   3.9.293.0 (080a254)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin.Android   4.20.0.34 (49a04b966feb40dfdba49d57ba16249b66d606a6)
Visual Studio plugin to enable development for Xamarin.Android.

Xamarin.iOS   8.6.1.0 (3b3ef438017c7ecf486defa9e01567a5f2b3cb2a)
Visual Studio extension to enable development for Xamarin.iOS.

Xamarin.iOS Unified Migration   1.0
Automated migration for Xamarin iOS Classic projects to Unified
Comment 2 Jason Smith [MSFT] 2015-02-11 08:41:57 UTC
Resolved in 1.3.4-pre2
Comment 3 Ian 2015-02-11 12:23:55 UTC
We are still getting the issue with 1.3.4.6328-pre2

Using the MenuCell.cs in the above comment we get the following "menu" without any space. It was working in 1.3.3 and below.

Here's the screen cast:

http://screencast.com/t/G3fjE7fihwIc
Comment 4 Jason Smith [MSFT] 2015-02-11 18:21:02 UTC
Thank you tracked and fixed. Will be resolved for 1.3.4 final (will mark fixed when branch is merged)