Bug 26887 - SWF.ToolStrip buttons wrongly respond to right clicks
Summary: SWF.ToolStrip buttons wrongly respond to right clicks
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: Windows.Forms ()
Version: 3.4.0
Hardware: PC Linux
: --- normal
Target Milestone: Community
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-02-09 19:01 UTC by Stephen McConnel
Modified: 2017-09-01 11:56 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
testcase (11.69 KB, application/zip)
2015-02-09 19:02 UTC, Stephen McConnel
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 26887 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Stephen McConnel 2015-02-09 19:01:44 UTC
ToolStrip.OnMouseUp() is calling OnItemClicked even for right (and center) mouse buttons.  It should only be invoked for the left mouse button.  At least, that's how the .Net libraries on Windows behave.

I'm attaching the project for a small program that allows you to easily demonstrate this behavior.

I will submit a pull request with my suggested fix soon.
Comment 1 Stephen McConnel 2015-02-09 19:02:26 UTC
Created attachment 9729 [details]
testcase
Comment 2 Stephen McConnel 2015-02-10 11:07:56 UTC
See https://github.com/mono/mono/pull/1557 for my proposed fix (which has already been merged).
Comment 3 Stephen McConnel 2015-02-25 18:02:05 UTC
My original fix is necessary but not sufficient.  There's another path through the code that generates OnItemClicked for right (and center) mouse buttons.  See
https://github.com/mono/mono/pull/1599 for my proposed fix that part of the code.