Bug 2684 - Implicit operator generate wrong code
Summary: Implicit operator generate wrong code
Status: RESOLVED FIXED
Alias: None
Product: Compilers
Classification: Mono
Component: C# ()
Version: unspecified
Hardware: PC Linux
: --- normal
Target Milestone: ---
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2011-12-29 09:27 UTC by Federico Di Gregorio
Modified: 2012-01-05 08:40 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Example that shows the bug (?) / behaviour (1.02 KB, text/x-csharp)
2011-12-29 09:27 UTC, Federico Di Gregorio
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Federico Di Gregorio 2011-12-29 09:27:00 UTC
Created attachment 1107 [details]
Example that shows the bug (?) / behaviour

I don't know if this is a bug or it is supposed to work this way but the MS compiler behaves differently, so I though to report it (with test case) anyway. While porting dotless to Mono we had to replace some operators (!=) with Object.Equals() to avoid getting always a "false" result, no matter what the instances compared. The problem seems to be an implicit cast to bool (e.g., "public static implicit operator bool (Node node)" and using Object.Equals() or casting the instances to object before the compare solves the problem. The problem doesn't show in MS compiler where the expected true/false result is returned.

I have attached a simple example that shows this behaviour.
Comment 1 Marek Safar 2012-01-05 08:40:22 UTC
Fixed in master