Bug 26757 - StackLayout not handling children height correctly causing overlapped views.
Summary: StackLayout not handling children height correctly causing overlapped views.
Status: VERIFIED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.3.1
Hardware: Macintosh Mac OS
: Normal normal
Target Milestone: 1.3.4
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2015-02-04 16:55 UTC by laygr
Modified: 2015-02-12 06:26 UTC (History)
7 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Sketch that reproduces the bug & image that shows it. (342.11 KB, application/zip)
2015-02-04 16:55 UTC, laygr
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description laygr 2015-02-04 16:55:17 UTC
Created attachment 9652 [details]
Sketch that reproduces the bug & image that shows it.

On the attached code, the views on the given StackLayout overlap.
I attach a sketch that reproduces the bug and an image that shows it.
Comment 1 Jason Smith [MSFT] 2015-02-05 06:53:37 UTC
Yeah thats a good catch. I suspect this will work with Grid right now its layout system is a little smarter but I will fix this
Comment 2 narayanp 2015-02-05 07:54:52 UTC
I have tried to reproduce this issue and able to reproduce. I downloaded the attached project sample and run it. I am also getting the same behaviour, StackLayout is overlapping views. 

Screencast: http://www.screencast.com/t/XBsNdfpppz2
Simulator Log : https://gist.github.com/Udham1/0642e64062b7d5713e93
Ide Log : https://gist.github.com/Udham1/221e020f44743a0017a9

Environment Info: 
=== Xamarin Studio ===

Version 5.7.1 (build 17)
Installation UUID: ce927b2a-2c07-44c5-b186-09cfdafba6dc
Runtime:
	Mono 3.12.0 ((detached/a813491)
	GTK+ 2.24.23 (Raleigh theme)

	Package version: 312000068

=== Apple Developer Tools ===

Xcode 6.1.1 (6611)
Build 6A2008a

=== Xamarin.iOS ===

Version: 8.6.1.24 (Business Edition)
Hash: 1ee873c
Branch: 
Build date: 2015-01-31 17:42:21-0500

=== Xamarin.Android ===

Version: 4.20.0.28 (Business Edition)
Android SDK: /Users/xamarin76/Desktop/android-sdk-macosx
	Supported Android versions:
		1.6    (API level 4)
		2.1    (API level 7)
		2.2    (API level 8)
		2.3    (API level 10)
		3.1    (API level 12)
		4.0    (API level 14)
		4.0.3  (API level 15)
		4.1    (API level 16)
		4.2    (API level 17)
		4.3    (API level 18)
		4.4    (API level 19)
		4.4.87 (API level 20)
		5.0    (API level 21)
Java SDK: /usr
java version "1.7.0_65"
Java(TM) SE Runtime Environment (build 1.7.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode)

=== Xamarin.Mac ===

Version: 1.12.0.4 (Business Edition)

=== Build Information ===

Release ID: 507010017
Git revision: 0bc7d3550b6b088ac25b08dcf7bbe73bcc8658b3
Build date: 2015-02-03 19:43:29-05
Xamarin addins: f7b7d34419c9ec24501bfa7c658e80a6305613e0

=== Operating System ===

Mac OS X 10.9.5
Darwin Xamarin76s-Mac-mini.local 13.4.0 Darwin Kernel Version 13.4.0
    Sun Aug 17 19:50:11 PDT 2014
    root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64
Comment 3 Jason Smith [MSFT] 2015-02-06 08:22:09 UTC
Not that it matters, but that sucked, I had to more or less re-write the stack layout engine :)

It works now :)

I added the background colors for debugging purposes, but you can see the result here: http://screencast.com/t/bmJkllYUq
Comment 4 laygr 2015-02-06 11:47:00 UTC
Great!
Yeah, before submitting the bug I had to analyze carefully my code and I realized that it wouldn't be trivial to solve it.
Comment 5 Jason Smith [MSFT] 2015-02-07 00:54:00 UTC
Fixed in 1.3.4-pre1

The fix has some performance implications so there may be optimization work needed in further releases. However correctness trumps performance in layout. It should be minimal.
Comment 6 Parmendra Kumar 2015-02-11 06:13:54 UTC
I have checked this issue with 1.3.4.6328-pre2, I am still getting same behavior.

Steps I have followed:

1. Create a Xamarin.Forms app.
2. Add a Sketch file.
3. Write attached code in Sketch file.
4. Run the sketch file.

Observed that I am getting same behavior mentioned in the comment #2.

Screencast: http://www.screencast.com/t/H8ovMD4pNio

Please refer the screencast and let me know if I have missed anything.
Comment 7 Jason Smith [MSFT] 2015-02-11 18:27:13 UTC
Fix cant be validated using sketches, sorry, you need to validate using an actual project. Sketches will need to be updated to reflect the fix at some point in the future.
Comment 8 Parmendra Kumar 2015-02-12 06:26:40 UTC
As per comment #7 I am rechecked this issue with Xamarin.Forms actual project and now its working fine at my end.

Screencast: http://www.screencast.com/t/Eh6ZDGlnUJcz

Xamarin.Forms: 1.3.4.6329-pre3

Hence closing this issue.