Bug 25548 - windows/cross 3.10.0 build failure at mono/utils/sha1.h, and the fix.
Summary: windows/cross 3.10.0 build failure at mono/utils/sha1.h, and the fix.
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: PC Linux
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-12-20 14:41 UTC by Hin-Tak Leung
Modified: 2015-01-02 18:39 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Hin-Tak Leung 2014-12-20 14:41:08 UTC
I have a cross build system which works well up to and including 3.4.0.
I have tried anything after that, but with 3.10.0, it fails
at compiling mono/utils/sha1.c. Apparently that's because
it uses __BEGIN_DECLS and __END_DECLS which are defined in the unix
system headers for declaring c++ linking of C code,
but not in mingw headers.

Here is the fix that works for me. Please adapt and/or commit.
You can use my Signed-Off: also.

--- ./mono/utils/sha1.h.orig	2014-10-04 10:27:43.000000000 +0100
+++ mono/utils/sha1.h	2014-12-19 19:14:29.043823338 +0000
@@ -21,6 +21,15 @@
     guint8 buffer[SHA1_BLOCK_LENGTH];
 } SHA1_CTX;
 
+/* C++ needs to know that types and declarations are C, not C++.  */
+#ifdef   __cplusplus
+# define __BEGIN_DECLS  extern "C" {
+# define __END_DECLS }
+#else
+# define __BEGIN_DECLS
+# define __END_DECLS
+#endif
+
 __BEGIN_DECLS
 void SHA1Init(SHA1_CTX *);
 void SHA1Pad(SHA1_CTX *);
Comment 1 Zoltan Varga 2015-01-02 18:39:29 UTC
This is already fixed in mono 3.12 and master.