Bug 2489 - Preferences->Build->Assembly Folders buttons grayed out when removing folder.
Summary: Preferences->Build->Assembly Folders buttons grayed out when removing folder.
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: General ()
Version: 2.6
Hardware: PC Linux
: Normal normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-12-13 18:36 UTC by John Combs
Modified: 2012-06-04 04:28 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
log file (7.84 KB, text/plain)
2011-12-13 18:36 UTC, John Combs
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description John Combs 2011-12-13 18:36:19 UTC
Created attachment 1041 [details]
log file

Description of Problem:
When removing a folder from the Preferences -> Build -> Assembly Folders dialog box all the buttons get grayed out. To add an assembly folder you have to exit out of the dialog.

Steps to reproduce the problem:
1. Have an assembly folder added in Preferences -> Build -> Assembly Folders dialog box.
2. Open the Preferences -> Build -> Assembly Folders dialog box.
2. Remove one of the assembly folders.

Actual Results:
All buttons get grayed out.

Expected Results:
Add and Update button should not be grayed out.

How often does this happen? 
Every time I remove an assembly folder.

Additional Information:
Attached is a log file of the console when this happens.
Comment 1 Jason Loeffler 2012-06-02 17:19:48 UTC
The resulting TreeIter from the remove was not being checked for validity properly prior to attempting to reselect the next item in the list. Also, the PathChanged event on the folder entry control was not mapped to UpdateStatus() so the Add button was not being reenabled when the box was populated.

I fixed the iterator check so that it no longer throws the errors described in the attachment.  I also added a handler for the PathChanged event so that as the user types or removes text in the folder entry box (or adds from the browse dialog) the status of the buttons is updated.

https://github.com/mono/monodevelop/pull/201
Comment 2 Lluis Sanchez 2012-06-04 04:28:33 UTC
Patch merged.