Bug 24625 - Rename OutputAudioQueue.OutputCompleted to OutputAudioQueue.BufferCompleted
Summary: Rename OutputAudioQueue.OutputCompleted to OutputAudioQueue.BufferCompleted
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: XI 8.4.0
Hardware: PC Mac OS
: --- enhancement
Target Milestone: Untriaged
Assignee: Sebastien Pouliot
URL:
: 24624 ()
Depends on:
Blocks:
 
Reported: 2014-11-18 13:10 UTC by Brendan Zagaeski (Xamarin Team, assistant)
Modified: 2014-11-18 15:33 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Brendan Zagaeski (Xamarin Team, assistant) 2014-11-18 13:10:12 UTC
Rename `AudioToolbox.OutputAudioQueue.OutputCompleted` to `AudioToolbox.OutputAudioQueue.BufferCompleted`

This is the exact same request as bug 24624, except for Xamarin.iOS rather than Xamarin.Mac. I'm filing it separately to help track it in both places, if the change is accepted.


This is a tiny API-breaking rename that might help prevent confusion about the meaning of the `OutputCompleted` event. Really this event is raised each time a _buffer_ is "completed" and ready for re-use, not when the whole output is completed.

I'm filing it just for consideration in the Unified API because that new API already breaks backwards compatibility.

See:
https://developer.apple.com/library/ios/documentation/musicaudio/Reference/AudioQueueReference/index.html#//apple_ref/c/tdef/AudioQueueOutputCallback


Thanks!
Comment 1 Sebastien Pouliot 2014-11-18 15:18:31 UTC
Agreed, it sounds like the current name is quite confusing.
Comment 2 Sebastien Pouliot 2014-11-18 15:19:08 UTC
*** Bug 24624 has been marked as a duplicate of this bug. ***
Comment 3 Sebastien Pouliot 2014-11-18 15:33:30 UTC
maccore / master b7a640e8bf5d5a8b7985bd19f7fcf656739a9989
monotouch / master (bump) 5a952c06b1ba2e13022bb81dcde9d136990cdfb6