Bug 23442 - Validate Bundle Identifier for allowable name
Summary: Validate Bundle Identifier for allowable name
Status: RESOLVED FIXED
Alias: None
Product: Xamarin.Mac
Classification: Desktop
Component: Other ()
Version: 1.11.0
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: Vincent Dondain [MSFT]
URL:
Depends on:
Blocks:
 
Reported: 2014-09-28 18:18 UTC by Cody Beyer (MSFT)
Modified: 2014-12-10 13:26 UTC (History)
4 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Cody Beyer (MSFT) 2014-09-28 18:18:15 UTC
Currently you can name your bundle an illegal name, and it will fail to install due to a javascript error.

Please validate this at creation and warn of illegal names. Example set as private comment.
Comment 2 Miguel de Icaza [MSFT] 2014-12-03 14:24:09 UTC
Vincent, 

This looks like a validation issue on the add-in, can you take over this?
Comment 3 Vincent Dondain [MSFT] 2014-12-03 14:30:46 UTC
Sure I'll take a look.
Comment 4 Chris Hamons 2014-12-03 17:03:22 UTC
Talk to jeff to make sure we use the same "valid name" logic. 

I'm pretty sure it's just [A-Za-z0-9_]
Comment 5 Vincent Dondain [MSFT] 2014-12-10 13:26:52 UTC
I fixed the potential source of the issue on md-addins/master. 

Commit: https://github.com/xamarin/md-addins/commit/bbb3469f582eb38153c57339ae4f9323a0e89f0c

XamMac2 templates used com.${AuthorCompany}.${Namespace} instead of com.your-company.${Namespace}

The problem was probably that customers don't usually verify their bundle identifier and didn't know it was wrong (until they create an installer). Now the default bundle id will work.

However we might consider adding some validation checks in Xamarin Studio but it's not on the roadmap for now.

I'm resolving this issue as fixed and will talk to Lluis about the different options we have for the validation.