Bug 23287 - [iPad] EditorRenderer NullReference
Summary: [iPad] EditorRenderer NullReference
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.2.3
Hardware: Macintosh Mac OS
: Normal normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-09-23 07:48 UTC by Martin Krkoska
Modified: 2016-03-16 12:42 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Martin Krkoska 2014-09-23 07:48:04 UTC
EditorRenderer throws a NullReferenceException in UpdateEditable on iPad (Idiom==Tablet), because InputAccessoryView is set only for Phones (in OnElementChanged method).
Comment 1 Udham Singh 2014-09-25 08:06:56 UTC
We have tried to reproduce this issue but not able to reproduce this. Could you please provide us a sample app/ steps, so that we can reproduce this issue at our end.

Also, please provide your complete environment info, you can get environment info via "Xamarin Studio -> About Xamarin Studio -> Show Details".

Thanks
Comment 2 Martin Krkoska 2014-09-25 08:11:23 UTC
Xamarin.Forms 1.2.3-pre3 and run it on iPad simulator (iPhone works)

public class App
	{
		public static Page GetMainPage ()
		{	
			return new ContentPage { 
				Content = new Editor {
					Text = "Hello, Forms!",
					VerticalOptions = LayoutOptions.CenterAndExpand,
					HorizontalOptions = LayoutOptions.CenterAndExpand,
				},
			};
		}
	}
Comment 3 Mike Jones 2014-09-26 05:14:27 UTC
I have had the same issues, and have found the issue is in the EditorRenderer.cs file within this method:

private void UpdateEditable()
		{
			base.Control.Editable = base.Element.IsEnabled;
			base.Control.UserInteractionEnabled = base.Element.IsEnabled;
			base.Control.InputAccessoryView.Hidden = !base.Element.IsEnabled;
		}

On iPad "base.Control.InputAccessoryView" is null, whereas on iPhone it is not.

Hope we can get a fix soon.

Thanks
Comment 4 Jason Smith [MSFT] 2016-03-16 12:42:03 UTC
Thank you for taking the time to submit this report. After reviewing the description of this bug, we no longer believe it affects the current version of Xamarin.Forms. If you are still experiencing the issue after updating your packages, please reopen this report with an attached reproduction.
 
For your convenience, we have created some reproduction best practices viewable here: https://gist.github.com/jassmith/92405c300e54a01dcc6d

Warm regards,
Xamarin Forms Team