Bug 21827 - WP - ContentPage not taking full space when coming from a page with ToolbarItems
Summary: WP - ContentPage not taking full space when coming from a page with ToolbarItems
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.2.2
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-08-05 11:34 UTC by mathieu.foreau
Modified: 2015-05-19 19:42 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
screenshots of what happen (15.41 KB, application/zip)
2014-08-05 11:34 UTC, mathieu.foreau
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description mathieu.foreau 2014-08-05 11:34:23 UTC
Created attachment 7587 [details]
screenshots of what happen

I have a first page with a `ToolbarItem` that `PushAsync` a second page; this second page does not have toolbar items.

The problem is that the second page does not take the full height on WP. On Android, when I use this, inside a navigation page, the second page is resized when displayed.

Here is a sample code. Three pages, each one having a button, only page 1 has toolbar items. Here is what they do:

  - button on page 1 shows page 2
  - button on page 2 shows page 3
  - button on page 3 goes back to page 2



		public class App
		{
			public static Page GetMainPage()
			{
				var rootPage = new Pages.RootPage_Test();
				if (Device.OS == TargetPlatform.WinPhone)
					return rootPage;
				else
					return new NavigationPage(rootPage);
			}
		}

		public class RootPage_Test : ContentPage
		{
			ToolbarItem toolbarItem;
			public RootPage_Test()
			{
				toolbarItem = new ToolbarItem("xxx", "FavsAddTo.png", () => { });
				ToolbarItems.Add(toolbarItem);
				Content = new Button
				{
					Text = "Hit me!",
					Command = new Command(async () => { await Navigation.PushAsync(new SecondPage()); })
				};
			}
			protected override void OnAppearing()
			{
				base.OnAppearing();
				if (Device.OS == TargetPlatform.WinPhone)
					this.ToolbarItems.Add(toolbarItem);
			}
			protected override void OnDisappearing()
			{
				base.OnDisappearing();
				if (Device.OS == TargetPlatform.WinPhone)
					//this.ToolbarItems.Remove(toolbarItem); // this does not work on WP when not in a NagivationPage!
					ToolbarItems.Clear();
			}
		}

		public class SecondPage : ContentPage
		{
			public SecondPage()
			{
				Content = new Button
				{
					Text = "Go third.",
					Command = new Command(async () => { await Navigation.PushAsync(new ThirdPage()); })
				};
			}
		}

		public class ThirdPage : ContentPage
		{
			public ThirdPage()
			{
				Content = new Button
				{
					Text = "Go back",
					Command = new Command(async () => { await Navigation.PopAsync(); })
				};
			}
		}


And the result is:

  - Button on page 2 does **not** take the full height when coming from page 1
  - Button on page 3 does take full space
  - Button on page 2 does the same when coming from page 3.
Comment 1 Ram Chandra 2015-01-12 10:32:31 UTC
I have checked this issue and with the help of test case mentioned in bug description I am able to reproduce this issue.

Steps I followed:

1. Create a Blank App (Xamarin.Forms Portable)
2. Write the code mentioned in bug description on App.cs file
3. Build and deploy the windows phone project in emulator and device.

I observed that when coming from a page with ToolbarItems, ContentPage is not taking full space on view.

Screencast: http://www.screencast.com/t/tyXtaOgCa

Debug output: https://gist.github.com/RamChBachkheti/ae48c0f595ebe03302b2

Additional Info: When I remove the following line from the App class I observed that ContentPage is taking full space when coming from a page with ToolbarItems. 

>if (Device.OS == TargetPlatform.WinPhone)
>return rootPage;
>else

Please let me know if I can provide more info to this issue.

Environment Info:

Xamarin.Forms.1.3.0.6292

Microsoft Visual Studio Professional 2013
Version 12.0.30723.00 Update 3
Microsoft .NET Framework
Version 4.5.51641

Installed Version: Professional

LightSwitch for Visual Studio 2013   06177-004-0447006-02641
Microsoft LightSwitch for Visual Studio 2013

Team Explorer for Visual Studio 2013   06177-004-0447006-02641
Microsoft Team Explorer for Visual Studio 2013

Visual Basic 2013   06177-004-0447006-02641
Microsoft Visual Basic 2013

Visual C# 2013   06177-004-0447006-02641
Microsoft Visual C# 2013

Visual C++ 2013   06177-004-0447006-02641
Microsoft Visual C++ 2013

Visual F# 2013   06177-004-0447006-02641
Microsoft Visual F# 2013

Visual Studio 2013 Code Analysis Spell Checker   06177-004-0447006-02641
Microsoft® Visual Studio® 2013 Code Analysis Spell Checker

Portions of International CorrectSpell™ spelling correction system © 1993 by Lernout & Hauspie Speech Products N.V. All rights reserved.

The American Heritage® Dictionary of the English Language, Third Edition Copyright © 1992 Houghton Mifflin Company. Electronic version licensed from Lernout & Hauspie Speech Products N.V. All rights reserved.

Windows Phone SDK 8.0 - ENU   06177-004-0447006-02641
Windows Phone SDK 8.0 - ENU

Application Insights Tools for Visual Studio Package   1.0
Application Insights Tools for Visual Studio

ASP.NET and Web Tools   12.3.50717.0
Microsoft Web Developer Tools contains the following components:
Support for creating and opening ASP.NET web projects
Browser Link: A communication channel between Visual Studio and browsers
Editor extensions for HTML, CSS, and JavaScript
Page Inspector: Inspection tool for ASP.NET web projects
Scaffolding: A framework for building and running code generators
Server Explorer extensions for Microsoft Azure Websites
Web publishing: Extensions for publishing ASP.NET web projects to hosting providers, on-premises servers, or Microsoft Azure

ASP.NET Web Frameworks and Tools 2012.2   4.1.21001.0
For additional information, visit http://go.microsoft.com/fwlink/?LinkID=309563

ASP.NET Web Frameworks and Tools 2013   5.2.20703.0
For additional information, visit http://www.asp.net/

Common Azure Tools   1.2
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Microsoft Advertising SDK for Windows Phone   
Microsoft Advertising SDK for Windows Phone
Build 

Microsoft Azure Mobile Services Tools   1.2
Microsoft Azure Mobile Services Tools

NuGet Package Manager   2.8.50926.663
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

Office Developer Tools for Visual Studio 2013 ENU   12.0.30626
Microsoft Office Developer Tools for Visual Studio 2013 ENU

PowerShell Tools   1.2
Provides file classification services using PowerShell

PreEmptive Analytics Visualizer   1.2
Microsoft Visual Studio extension to visualize aggregated summaries from the PreEmptive Analytics product.

SQL Server Data Tools   12.0.30919.1
Microsoft SQL Server Data Tools

Windows Phone 8.1 SDK Integration   1.0
This package integrates the tools for the Windows Phone 8.1 SDK into the menus and controls of Visual Studio.

Workflow Manager Tools 1.0   1.0
This package contains the necessary Visual Studio integration components for Workflow Manager.

Xamarin   3.8.150.0 (10cfd178d55287f09c85f5a1e604dfe20889a40f)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin.Android   4.20.0.28 (ba9bbbdd44cfdc4bf485e8885bd2ad24fba525f7)
Visual Studio plugin to enable development for Xamarin.Android.

Xamarin.iOS   8.4.0.0 (840a925103a0bf4a856507f13d5eaee3c1579c2f)
Visual Studio extension to enable development for Xamarin.iOS.

Xamarin.iOS Unified Migration   1.0
Automated migration for Xamarin iOS Classic projects to Unified
Comment 2 Eric Maupin 2015-05-19 19:42:16 UTC
This appears to be fixed in the current version.