Bug 2172 - It is very hard to not duplicate MSBuildItems in a Project
Summary: It is very hard to not duplicate MSBuildItems in a Project
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Project Model ()
Version: Trunk
Hardware: PC Mac OS
: Normal normal
Target Milestone: ---
Assignee: Lluis Sanchez
URL:
Depends on:
Blocks:
 
Reported: 2011-11-23 11:32 UTC by Alan McGovern
Modified: 2015-07-02 10:43 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Alan McGovern 2011-11-23 11:32:50 UTC
The root of bug #1508 is that it is very hard to get the corresponding MSBuildItem item from a ProjectItem. All ProjectItems which are procossed by the

MSBuildProjetHandler.SaveItem (MonoDevelop.Core.IProgressMonitor monitor, MSBuildSerializer ser, MSBuildProject msproject, object ob, Dictionary<string,ItemInfo> oldItems)

method are currently being duplicated in the Project due to Project.AddNewItem being called without any kind of checking to see if the item is already in the project. The 'SaveProjectFile' function works around this by having a customised 'AddOrGetBuildItem' method which it calls.

This sort of functionality should be baked in to completely eliminate this bug. This would also remove the need for the (broken) remove duplicates check in MSBuildProjectHandler.SaveItem (currently about line 958 which starts with "// Remove old items". This is the check which failed to remove the duplicate WebReferences as it only checked duplicates based on MSBuildItem.Name and Include which was not enough.
Comment 1 Lluis Sanchez 2015-07-02 10:43:53 UTC
All this is fixed in XS 6.0