Bug 2169 - ObservableCollection's constructor is incorrect
Summary: ObservableCollection's constructor is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: WindowsBase ()
Version: 2.10.x
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-11-23 09:23 UTC by Anonymous
Modified: 2011-11-24 08:00 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Anonymous 2011-11-23 09:23:42 UTC
The constructor
public ObservableCollection(List<T> list)
has an incorrect implementation: it only passes the source list to its base (which is Collection<>).

As read in the DotNet documentation, and tested in reality, this constructor should create a new list and duplicate the items (one by one) of the source list.

The practical difference is that in the current Mono implementation we have only one list with two references, but in DotNet we have two different lists.
So a program based on this wrong assumption can work fine in Mono but not in dotnet.
That provoked a bug in my program, for example.

See here for more info: http://msdn.microsoft.com/en-us/library/ms653202
"The elements are *copied* onto the ObservableCollection(Of T) in the same order they are read by the enumerator of the list."
Comment 1 Marek Safar 2011-11-24 08:00:19 UTC
Fixed in master