Bug 2159 - regression in form closing event ordering
Summary: regression in form closing event ordering
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: Windows.Forms ()
Version: 2.10.x
Hardware: PC Linux
: Lowest normal
Target Milestone: Community
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-11-22 13:38 UTC by Julian Taylor
Modified: 2017-09-01 11:56 UTC (History)
2 users (show)

Tags: mono-community
Is this bug a regression?: ---
Last known good build:


Attachments
program to reproduce (4.83 KB, application/x-gzip)
2011-11-22 13:38 UTC, Julian Taylor
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 2159 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Julian Taylor 2011-11-22 13:38:15 UTC
Created attachment 932 [details]
program to reproduce

since this commit: https://github.com/mono/mono/commit/cc39d7ebf1bfa8fafd6adc3a9fda354672579d1c
System.Windows.Forms.FormClosingEventHandler fires before button click events, even if it is the click even that closes the form.
This is not the case in windows .net, mono < 2.10 and mono 2.10.5 with that commit reverted.
It breaks e.g. keepass which relies on that ordering:
http://sourceforge.net/tracker/?func=detail&atid=609908&aid=3429001&group_id=95013

attached pretty minimal program reproduces the issue.
extract and build with xbuild. when executing and click on test and then on ok.
without that commit the expected ordering
$ mono bin/Debug/InputBoxSample.exe
ok
closing

with mono 2.10.5 including above commit the order is reversed:
$ mono bin/Debug/InputBoxSample.exe
closing
ok

I failed to compile trunk but the code seems unchanged there.
Comment 1 Tom 2012-01-28 08:00:17 UTC
I'm also having this issue, miss firing form events are making a mess of things, happy to test any patches. I'm on mono 2.10.8 release.