Bug 21417 - Android Modal page has unwanted ActionBar even though it's not wrapped in a NavigationPage
Summary: Android Modal page has unwanted ActionBar even though it's not wrapped in a N...
Status: RESOLVED FIXED
Alias: None
Product: Forms
Classification: Xamarin
Component: Forms ()
Version: 1.2.2
Hardware: PC Windows
: Normal normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-07-17 19:58 UTC by Chase Florell
Modified: 2015-05-19 16:43 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Visual representation of the issue (88.04 KB, image/png)
2014-07-17 19:59 UTC, Chase Florell
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Chase Florell 2014-07-17 19:58:16 UTC
I've got a MasterDetail page that uses PushModalAsync(new AuthPage()); to push my login page over top of my main page.

The auth page is a TabbedPage with two ContentViews (one for Sign In and one for Register).

I've searched my entire source code to see if I'm setting anything as a NavigationPage and the only spot is definitely the Detail portion of the MD Page.

Now the issue comes in that when that AuthPage is pushed as a Modal, it still has a navigation bar in android (it's fine in iOS). The navigation bar has the left carret and no text. When pressed, nothing happens. This was not the case (with the same code) in v1.1.1

Use the below code to reproduce.

See the attached screenshot to see what I'm describing.

    public class App
    {
        public static INavigation Navigation;
        public static Page GetMainPage()
        {
            return new RootPage();
        }
    }

    public class RootPage : MasterDetailPage
    {
        public RootPage()
        {
            Title = "TabbedPage as a Modal case";

            var master = new Menu();
            var detail = new NavigationPage(new MainPage());

            if (App.Navigation == null)
            {
                App.Navigation = detail.Navigation;
            }

            Master = master;
            Detail = detail;
        }

        protected override async void OnAppearing()
        {
            base.OnAppearing();
            await App.Navigation.PushModalAsync(new ModalTabbedPage());
        }
    }

    public class ModalTabbedPage : TabbedPage
    {
        public ModalTabbedPage()
        {
            var firstTab = new FirstContentPage {Title = "First Tab"};
            var secondTab = new SecondContentPage { Title = "Second Tab" };

            Title = "title";

            Children.Add(firstTab);
            Children.Add(secondTab);
        }
    }

    public class SecondContentPage : ContentPage
    {
        public SecondContentPage()
        {
            Content = new Label {Text = "Second Content Page"};
        }
    }

    public class FirstContentPage : ContentPage
    {
        public FirstContentPage()
        {
            Content = new Label { Text = "First Content Page" };
        }
    }

    public class MainPage : ContentPage
    {
        public MainPage()
        {
            Content = new Label { Text = "Main Page", VerticalOptions = LayoutOptions.CenterAndExpand, HorizontalOptions = LayoutOptions.CenterAndExpand };
        }
    }

    public class Menu : ContentPage
    {
        public Menu()
        {
            Title = "My App";
            Content = new Label { Text = "Menu", VerticalOptions = LayoutOptions.CenterAndExpand, HorizontalOptions = LayoutOptions.CenterAndExpand };
        }
    }
Comment 1 Chase Florell 2014-07-17 19:59:14 UTC
Created attachment 7414 [details]
Visual representation of the issue
Comment 2 Michael 2015-05-19 16:43:26 UTC
I have verified the navigation bar is not visible on Android using Xamarin.Forms 1.4.2.