Bug 20682 - Incompatible definition of BitmapData type
Summary: Incompatible definition of BitmapData type
Status: NEW
Alias: None
Product: Class Libraries
Classification: Mono
Component: libgdiplus ()
Version: master
Hardware: PC All
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-06-18 11:13 UTC by Andrea Canciani
Modified: 2014-06-18 11:13 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 20682 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Andrea Canciani 2014-06-18 11:13:51 UTC
As stated both in src/GdiPlusFlat.h and src/bitmap-private.h the private definition of BitmapData used in libgdiplus does not match that of the MS GDI+ definition.

The library writes to the additional fields of the private definition even if it is unable to check which definition is being used by the caller. This can result in invalid writes (as shown in the testbits test).

Currently this issue is not hit in Mono because in BitmapData.cs the definition of the BitmapData structure is kept in sync with the one which is internal to libgdiplus, but it might be desirable to eventually fix this by making the structure match that of the MS definition. This would remove the need to special-case the use of libgdiplus in System.Drawing (vs the use of the original GDI+ lib).