Bug 17838 - IDictionary item property implemention for ConcurrentDictionary throws exception on non-existing key
Summary: IDictionary item property implemention for ConcurrentDictionary throws except...
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: mscorlib ()
Version: master
Hardware: PC Linux
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-02-18 05:45 UTC by hartmann.simon
Modified: 2014-02-19 12:00 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
test case (634 bytes, text/plain)
2014-02-18 05:46 UTC, hartmann.simon
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description hartmann.simon 2014-02-18 05:45:33 UTC
The IDicionary implementation for the item property get thows a KeyNotFoundException if the specified key does not exist in the dictionary - but according to the msdn documentation it should just return null.

See: http://msdn.microsoft.com/en-us/library/system.collections.idictionary.item%28v=vs.110%29.aspx

I attached a small test case
Comment 1 hartmann.simon 2014-02-18 05:46:05 UTC
Created attachment 6080 [details]
test case
Comment 2 hartmann.simon 2014-02-18 07:08:25 UTC
i fixed the behavior - just checking additionally with ContainsKey before entering the get item property implementation of ConcurrentDictionary itself

https://github.com/mono/mono/pull/903

I also added the unit test - hope this helps

cheers,
simon
Comment 3 Rodrigo Kumpera 2014-02-19 12:00:15 UTC
Fixed in https://github.com/mono/mono/pull/903