Bug 17665 - UriParseComponents incorrectly parse when uri contains @
Summary: UriParseComponents incorrectly parse when uri contains @
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System ()
Version: unspecified
Hardware: PC Linux
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2014-02-08 16:19 UTC by Scott Waye
Modified: 2014-02-12 11:08 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
code to reproduce (459 bytes, text/plain)
2014-02-08 16:19 UTC, Scott Waye
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Scott Waye 2014-02-08 16:19:15 UTC
Created attachment 6009 [details]
code to reproduce

In ParseUser at line 129 there is the odd looking:

if (ch == '@' || ch == '/' && ch == '#' && ch == '?')

I think this should be

if (ch == '@' || ch == '/' || ch == '#' || ch == '?')

to stop the search for user information continuing into the path/query/anchor. 

The attached outputs 

https://a.net/1@1.msg

using Microsofts System,

but Mono (3.2.6) outputs:

https://1.msg/

If its changed to all ||s then you get the same output
Comment 1 Miguel de Icaza [MSFT] 2014-02-12 11:08:31 UTC
Thanks for the bug report!
Fixed on master.