Bug 16742 - XmlConvert.ToDateTime(string, XmlDateTimeSerializationMode) throws index out of bounds exception on some valid XML dateTime representations
Summary: XmlConvert.ToDateTime(string, XmlDateTimeSerializationMode) throws index out ...
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System.XML ()
Version: 3.2.x
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2013-12-11 14:04 UTC by Horst Kakuschke
Modified: 2014-02-12 15:24 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Horst Kakuschke 2013-12-11 14:04:57 UTC
XmlConvert.ToDateTime(string, XmlDateTimeSerializationMode) throws an "index out of bounds" exception in 
DateTime._DoParse() when the xml dateTime string is e.g.
- "2003-09-26T13:30:44Z"
- "2003-09-26T13:30:44+13:00".

On the other hand, converting of "2003-09-26T13:30:44" works fine.

To reproduce the exception:

  DateTime x = XmlConvert.ToDateTime("2003-09-26T13:30:44Z", XmlDateTimeSerializationMode.Local);
Comment 1 Horst Kakuschke 2013-12-11 14:27:03 UTC
Primary culprit was a index check in Corlib/System/DateTime.cs - fixed.

Added tests for method XmlConvert.ToDateTime(string, XmlDateTimeSerializationMode) in System.XML/Test/System.XML/XmlConvertTests.cs and found quite a few differences between MS .NET and Mono (ran the tests first in .NET, then on Mono).

Fixed these differences in System.XML/System.Xml/XmlConvert.cs: now .NET and Mono yield the same results.

Created GitHub pull request #835 - please check.
Comment 2 Miguel de Icaza [MSFT] 2014-02-12 15:24:38 UTC
Thanks for the fixes, merged both patches.