Bug 15909 - [enhancement] Suggest const field for repeated DllImport attributes
Summary: [enhancement] Suggest const field for repeated DllImport attributes
Status: NEW
Alias: None
Product: Tools
Classification: Mono
Component: Gendarme ()
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2013-11-04 14:19 UTC by Andres G. Aragoneses
Modified: 2013-11-04 14:19 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report for Bug 15909 on GitHub or Developer Community if you have new information to add and do not yet see a matching new report.

If the latest results still closely match this report, you can use the original description:

  • Export the original title and description: GitHub Markdown or Developer Community HTML
  • Copy the title and description into the new report. Adjust them to be up-to-date if needed.
  • Add your new information.

In special cases on GitHub you might also want the comments: GitHub Markdown with public comments

Related Links:
Status:
NEW

Description Andres G. Aragoneses 2013-11-04 14:19:40 UTC
Gendarme should probably suggest that this kind of code:

[DllImport ("libglib-2.0-0.dll")]
static extern IntPtr g_malloc(IntPtr size);

[DllImport ("libglib-2.0-0.dll")]
static extern void g_free (IntPtr mem);

Should be converted to this:

const string dll = "libglib-2.0-0.dll";

[DllImport (dll)]
static extern IntPtr g_malloc(IntPtr size);

[DllImport (dll)]
static extern void g_free (IntPtr mem);

Because it is less verbose, less redundant, and more maintainable (it prevents changing the library name in only one place instead of in N places).