Bug 15877 - DrawerLayout.CloseDrawer(int gravity) should be DrawerLayout.CloseDrawer(GravityFlags gravity)
Summary: DrawerLayout.CloseDrawer(int gravity) should be DrawerLayout.CloseDrawer(Grav...
Status: RESOLVED NOT_ON_ROADMAP
Alias: None
Product: Components
Classification: Xamarin
Component: Xamarin Components ()
Version: N/A
Hardware: All All
: Normal enhancement
Target Milestone: ---
Assignee: Jon Dick
URL:
Depends on:
Blocks:
 
Reported: 2013-11-01 10:26 UTC by Leon Lucardie
Modified: 2015-11-05 17:08 UTC (History)
5 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED NOT_ON_ROADMAP

Description Leon Lucardie 2013-11-01 10:26:24 UTC
The DrawerLayout widget contained in the Xamarin.Android.Support.v4-18 assembly contains a CloseDrawer(int gravity) method. To conform to Xamarin convention, shouldn't this method accept GravityFlags as a parameter instead?
Comment 2 Atsushi Eno 2014-01-09 08:48:26 UTC
This is now fixed. Thanks for the report.

[master 4277975] [{monodroid-bindings} master 7db8763]
Comment 3 Udham Singh 2014-03-28 13:01:17 UTC
I have checked this issue on following builds:

Mac 10.9.2
Windows 8.1
Xamarin Studio : 4.2.3 (build 60)
Xamarin.Android : 4.13.0

Screencast: http://screencast.com/t/orxSj3bhEGb

I am still getting parameter gravity of int type in CloseDrawer(int gravity) method. Hence, I am reopening this issue.
Comment 4 Peter Collins 2014-04-03 17:48:32 UTC
The CloseDrawer parameter has been changed to accept a GravityFlags value instead of int on the latest from master. XA 4.14 will contain the fix when we branch for that, you'll need a version equal to or greater than mono-android-4.13.0-177 to verify the fix.
Comment 5 Udham Singh 2015-07-13 05:11:03 UTC
I have checked this issue on below environment and still observing the reported behaviour. Hence I am reopening this issue.

Screencast : http://www.screencast.com/t/c8rM76qM

=== Xamarin Studio ===

Version 5.9.4 (build 5)
Installation UUID: ce927b2a-2c07-44c5-b186-09cfdafba6dc
Runtime:
    Mono 4.0.2 ((detached/c99aa0c)
    GTK+ 2.24.23 (Raleigh theme)

    Package version: 400020005

=== Apple Developer Tools ===

Xcode 6.2 (6776)
Build 6C131e

=== Xamarin.Android ===

Version: 5.1.4.16 (Enterprise Edition)
Android SDK: /Users/xamarin76/Desktop/android-sdk-macosx
    Supported Android versions:
        2.3    (API level 10)
        4.0.3  (API level 15)
        4.1    (API level 16)
        4.2    (API level 17)
        4.3    (API level 18)
        4.4    (API level 19)
        4.4.87 (API level 20)
        5.0    (API level 21)
Java SDK: /usr
java version "1.7.0_65"
Java(TM) SE Runtime Environment (build 1.7.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode)

=== Build Information ===

Release ID: 509040005
Git revision: 8010a90f6e246b32364e3fb46ef2c9d1be9c9a2b
Build date: 2015-06-08 16:52:06-04
Xamarin addins: 7e93e9c3503f28770f23ce1b7eafd829919f18e8

=== Operating System ===

Mac OS X 10.9.5
Darwin Xamarin76s-Mac-mini.local 13.4.0 Darwin Kernel Version 13.4.0
    Sun Aug 17 19:50:11 PDT 2014
    root:xnu-2422.115.4~1/RELEASE_X86_64 x86_64
Comment 6 Atsushi Eno 2015-07-16 05:04:27 UTC
Unlike when I fixed the original issue in 2013 in monodroid-bindings repo, everything has moved to the components team and I don't control it. They need to fix their bindings.
Comment 7 Jon Dick 2015-07-31 10:30:36 UTC
This is a nice to have enhancement.

You can currently either use GravitFlags.Left or GravityFlags.Right cast to an int, or you can use Android.Support.V4.View.GravityCompat.Start or Android.Support.V4.View.GravityCompat.Start as values.
Comment 8 David Humphreys 2015-11-05 17:08:30 UTC
This is not on the roadmap to be implemented, I'm afraid.  Sorry