Bug 1558 - [PATCH] Calling CreateNavigator on editable XPathNavigator returns non editable Navigator.
Summary: [PATCH] Calling CreateNavigator on editable XPathNavigator returns non editab...
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System.XML ()
Version: master
Hardware: PC Windows
: --- normal
Target Milestone: Untriaged
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-10-19 06:16 UTC by Tom Hindle
Modified: 2012-01-19 06:03 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Test case showing issue. (456 bytes, text/plain)
2011-10-19 06:16 UTC, Tom Hindle
Details
patch to fix issue by enhancing XmlDocumentNavigator (1.09 KB, patch)
2011-10-19 08:02 UTC, Tom Hindle
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Tom Hindle 2011-10-19 06:16:09 UTC
Created attachment 718 [details]
Test case showing issue.

Given a editable XPathNavigator (XmlDocumentEditableNavigator on mono) - calling CreateNavigator returns a XmlDocumentNavigator.

This means that calling SetValue method always returns NotSupportedException.

as shown in this code snippet:

XmlDocument document = new XmlDocument();
document.LoadXml("<div>hello world</div>");
XPathNavigator navigator = document.CreateNavigator().CreateNavigator();			
navigator.SelectSingleNode("//div").SetValue("hello world 2");


Attached test case expected output:
<div>hello world 2</div>

Actually test case output:
Unhandled Exception: System.NotSupportedException: Operation is not supported.
  at System.Xml.XPath.XPathNavigator.SetValue (System.String value) [0x00000] in
 C:\cygwin\tmp\monobuild\build\BUILD\mono-2.10.2\mcs\class\System.XML\System.Xml
.XPath\XPathNavigator.cs:1422
  at SetValueTest.SetValueTest.Main (System.String[] args) [0x0001f] in SetValue
Test\SetValueTest.cs:14
Comment 1 Tom Hindle 2011-10-19 08:02:27 UTC
Created attachment 719 [details]
patch to fix issue by enhancing XmlDocumentNavigator
Comment 2 Atsushi Eno 2012-01-19 06:03:47 UTC
Sorry for the late reply and thanks for the fix suggestion. Fixed the issue in git master e642e68.
I think this has to be fixed rather in XPathEditableNavigator that returned non-editable navigator. Now it returns just a clone so the returned navigator is still editable and your test case now works.