Bug 15322 - Pair and Unpair buttons are slightly misleading.
Summary: Pair and Unpair buttons are slightly misleading.
Status: VERIFIED FIXED
Alias: None
Product: Visual Studio Extensions
Classification: Xamarin
Component: iOS ()
Version: 0.x Insider Preview
Hardware: PC Windows
: Normal normal
Target Milestone: 1.6.x (connection)
Assignee: Dominique Louis
URL:
Depends on:
Blocks:
 
Reported: 2013-10-10 09:50 UTC by narayanp
Modified: 2015-01-05 11:21 UTC (History)
8 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description narayanp 2013-10-10 09:50:56 UTC
Steps to reproduce:
[Condition: Build host should not be connected to any VS]
1. Open VS.
2. Go to Tools->Options->Xamarin->iOS Settings
3. Click 'Find Mac Build Host' button.
4. Select the build host which is not connected to any VS.
5. Go to same build host and open 'Xamarin.iOS Build Host' window.

Actual Result: It is displaying two buttons 'Open Log' and 'Unpair' button Instead of only 'Pair' button. However when user click on 'Unpair' button the it display 'Pair' button.

Expected Result: When Build Host is not connected to any VS and user open 'Xamarin.iOS Build Host' window on build host, It should displayed 'Pair button' instead of 'Unpair' button as mentioned in screencast: http://www.screencast.com/t/ESShGkhu

Environment details:
All Mac
VS 2013/2012/2010
iOS for VS 1.6.77
X.iOS 7.0.2.43
Comment 1 Dominique Louis 2013-10-10 10:32:04 UTC
the screencast clearly shows an old 6.x version of MT.
Comment 2 PJ 2013-10-10 13:25:14 UTC
The case is still somewhat valid, and will be replaced by the results of our discussion today.

The button will now read this way:

While there is an mtbserver-gui.dat file representing an active PIN in ~/Library/Xamarin/mtbsever-gui.dat, the button will read [Invalidate PIN]

While there is not and mtbsever-gui.dat file, the button will read [Generate PIN]

There will also be label updates in the middle of the build host.

Requirements:
    When [Generate Pin] is pressed:
        Create ~/Library/Xamarin/mtbsever-gui.dat
        Update label to read (something like): 'You are now accepting connections from
        VS instances configured with the most recently generated PIN'

    When [Invalidate PIN] is pressed:
        If there is still a ~/Library/Xamarin/mtbsever-gui.dat file (in case somebody manually removed it)
            Remove the file at ~/Library/Xamarin/mtbsever-gui.dat
            Update label to read (something like): 'To allow incoming connections from Visual Studio, 
            please generate a PIN, initiate a connection to the build host from VS, and enter the generated PIN.'
Comment 3 PJ 2013-10-10 16:38:07 UTC
Current text reads:


Clicking 'Invalidate PIN' will delete the PIN and this machine will NO longer be visible on the network.

Clicking 'Generate PIN', will generate a new PIN and allow this machine to be discoverable on the network.


Small proposed changes:

Clicking 'Invalidate PIN' will *invalidate any existing connection* and this machine will NO longer be visible on the network.

Clicking 'Generate PIN'** will generate a new PIN and allow this machine to be discoverable on the network.
 (I removed the comma)


I don't mean to copy-edit very heavily, but I think the comma removal is pretty minor and I think 'invalidate any existing connection' is more clear than 'delete the PIN', and preps the user for their existing connection to be killed.

Looks a ton better though already, and is *much* more clear!!
Comment 4 Dominique Louis 2013-10-11 04:36:51 UTC
Suggested Changes should be part of https://wrench.internalx.com/Wrench/ViewLane.aspx?lane_id=717&host_id=69&revision_id=208955
Comment 5 narayanp 2013-10-14 06:12:46 UTC
Today I have checked this issue with following builds:

All Windows
VS 2010/2012/2013
iOS for VS 1.6.86
X.iOS 7.0.2.78

Now we observed that:

1. when mtbsever-gui.dat exists, Button displayed as 'Invalidated PIN' and when mtbsever-gui.dat does not exist, button displayed as 'Generate PIN'.

2. If we click on Invalidated PIN then it does not visible on any windows. While if we click on 'Generate PIN' button then it display on all windows machine.

3. After clicking on Generate PIN, it generate PIN code.

Changing the status to Verified.