Notice (2018-05-24): bugzilla.xamarin.com is now in
Please join us on
Visual Studio Developer Community and in the
Mono organizations on
GitHub to continue tracking issues. Bugzilla will remain
available for reference in read-only mode. We will continue to work
on open Bugzilla bugs, copy them to the new locations
as needed for follow-up, and add the new items under Related
Our sincere thanks to everyone who has contributed on this bug
tracker over the years. Thanks also for your understanding as we
make these adjustments and improvements for the future.
Please create a new report on
GitHub or Developer Community with
your current version information, steps to reproduce, and relevant error
messages or log files if you are hitting an issue that looks similar to
this resolved bug and you do not yet see a matching new report.
There are 2 visible problems with BinaryReader.ReadString.
- The read loop use `readLen' to compute the amount of bytes left to be read where it should use the result of `m_stream.Read' method instead
- More cosmetic but the buffers seems initialized in the wrong order i.e. this:
> charBuffer = new char [m_encoding.GetMaxByteCount (MaxBufferSize)];
> charByteBuffer = new byte [MaxBufferSize];
> charBuffer = new char [MaxBufferSize];
> charByteBuffer = new byte [m_encoding.GetMaxByteCount (MaxBufferSize)];
It would be good to have unit test with a stream wrapper that keep on returning 1-byte even when caller requests more to verify those kind of bad behaviors.
Fixed in master
*** Bug 17655 has been marked as a duplicate of this bug. ***