Bug 15143 - BinaryReader.ReadString problems
Summary: BinaryReader.ReadString problems
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: mscorlib ()
Version: 3.2.x
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
URL:
: 17655 ()
Depends on:
Blocks:
 
Reported: 2013-10-02 17:42 UTC by Jérémie Laval
Modified: 2014-02-12 18:36 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Jérémie Laval 2013-10-02 17:42:24 UTC
There are 2 visible problems with BinaryReader.ReadString.

- The read loop use `readLen' to compute the amount of bytes left to be read where it should use the result of `m_stream.Read' method instead

- More cosmetic but the buffers seems initialized in the wrong order i.e. this:

> charBuffer = new char [m_encoding.GetMaxByteCount (MaxBufferSize)];
> charByteBuffer = new byte [MaxBufferSize];

should be:

> charBuffer = new char [MaxBufferSize];
> charByteBuffer = new byte [m_encoding.GetMaxByteCount (MaxBufferSize)];

It would be good to have unit test with a stream wrapper that keep on returning 1-byte even when caller requests more to verify those kind of bad behaviors.
Comment 1 Marek Safar 2014-01-17 16:00:55 UTC
Fixed in master
Comment 2 Alan McGovern 2014-02-12 18:36:05 UTC
*** Bug 17655 has been marked as a duplicate of this bug. ***