Bug 1473 - Pre-edit double-underlines do not render
Summary: Pre-edit double-underlines do not render
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Text Editor ()
Version: Trunk
Hardware: PC Windows
: --- major
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2011-10-13 07:16 UTC by Mikayla Hutchinson [MSFT]
Modified: 2011-10-31 09:20 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Mikayla Hutchinson [MSFT] 2011-10-13 07:16:03 UTC
Pre-edit strings may have a double-underline attribute, which is a important indicator for editing, but the double underline doesn't render because it extends slightly below the bottom of the line.
Comment 2 Mike Krüger 2011-10-25 06:27:21 UTC
I submitted a patch, but since I can't repro it on my system I need feedback about it.
Comment 3 Mikayla Hutchinson [MSFT] 2011-10-31 06:58:12 UTC
It works but it makes *all* the lines in the editor permanently higher.

It would be better just to overpaint it IMO instead of adjusting the screen size.
Comment 4 Mikayla Hutchinson [MSFT] 2011-10-31 07:05:54 UTC
Bumping to major since making all the lines taller looks really weird.
Comment 5 Mike Krüger 2011-10-31 08:12:44 UTC
The screencast does that too btw. - since I couldn't reproduce it I couldn't see how it looks :/

I'll try to make only the line higher that contains the pre-edit string.
Comment 6 Mikayla Hutchinson [MSFT] 2011-10-31 08:19:06 UTC
Other texteditors on Windows simply overpaint it and don't resize anything, e.g. notepad: http://screencast.com/t/AQyH68DH
Comment 7 Mike Krüger 2011-10-31 09:04:37 UTC
I now use the height tree to make only 1 line taller. Should look better now.
Comment 8 Mike Krüger 2011-10-31 09:07:16 UTC
mhutch: our drawing can't overpaint :) - I think resizing is the way to go and now that the editor can handle single line height changes it should use them.

I simply couldn't see how it looks. I just did mimic the gtk widget behaviour - from looks it made all lines taller. Which I found a bit weird - that's why I asked for feedback.

How is this now looking ?
Comment 9 Mikayla Hutchinson [MSFT] 2011-10-31 09:20:37 UTC
Looks fine :)