Bug 14456 - TypeDescriptor.Getconverter stops working when linker behavior is set to "Link all assemblies"
Summary: TypeDescriptor.Getconverter stops working when linker behavior is set to "Lin...
Status: RESOLVED FIXED
Alias: None
Product: iOS
Classification: Xamarin
Component: Xamarin.iOS.dll ()
Version: 6.2.x
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Sebastien Pouliot
URL:
Depends on:
Blocks:
 
Reported: 2013-09-05 09:10 UTC by bilal.durrani
Modified: 2013-09-06 10:28 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description bilal.durrani 2013-09-05 09:10:36 UTC
I'm using TypeConverters and I noticed when I set the linker to Link all assemblies, TypeDescriptor.GetConverter fails to return the typeconverter I specified with an attribute.

Here is the code i tried

[TypeConverter(typeof(TestEnumTypeConverter))]
public enum TestEnum
{
    One,Two
}


public class TestEnumTypeConverter:TypeConverter
{
    public override object ConvertTo (ITypeDescriptorContext context, System.Globalization.CultureInfo culture, object value, Type destinationType)
    {
        return "hello";
    }
}
Then in your ViewDidLoad, call the following

var tc = TypeDescriptor.GetConverter(typeof(TestEnum));
Console.WriteLine(tc.GetType().ToString());

With the default linker option, I get the correct TypeConverter. With the Link all option, I always get System.ComponentModel.EnumConverter

Adding [Preserve] to the TestEnumTypeConverter didn't help either
Comment 1 Sebastien Pouliot 2013-09-06 10:28:41 UTC
The attribute is being removed. Fixed in master 5c4f362d3824943f7ba8c720ecce90a073d107bd

Adding `[Preserve (AllMembers = true)]` (on TestEnumTypeConverter) will make this work in future releases.

QA: unit test added in the same revision