Bug 13523 - System.CodeDom generates invalid C# code.
Summary: System.CodeDom generates invalid C# code.
Status: RESOLVED FIXED
Alias: None
Product: Class Libraries
Classification: Mono
Component: System ()
Version: unspecified
Hardware: PC Mac OS
: --- normal
Target Milestone: Untriaged
Assignee: Marek Safar
URL:
Depends on:
Blocks:
 
Reported: 2013-07-26 13:34 UTC by Jonathan Pryor
Modified: 2013-07-30 14:19 UTC (History)
2 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Jonathan Pryor 2013-07-26 13:34:19 UTC
Context: https://github.com/mono/mono/commit/e43a6401f8f2989263f80df7538c5e717e550d2d#commitcomment-3726073

Consider the following program:

  $ cat > cdom.cs <<EOF
  using System;
  using System.CodeDom;
  using System.CodeDom.Compiler;

  class Test {
    public static void Main ()
    {
      var gen = CodeDomProvider.CreateProvider ("C#");
      var code = new CodeCompileUnit () {
        AssemblyCustomAttributes = {
          new CodeAttributeDeclaration (
            new CodeTypeReference (typeof (CLSCompliantAttribute)),
            new CodeAttributeArgument (new CodePrimitiveExpression (false))),
        },
        Namespaces = {
          new CodeNamespace () {
            Types = {
              new CodeTypeDeclaration ("Resources"),
            },
          }
        },
      };
      gen.GenerateCodeFromCompileUnit (code, Console.Out, null);
    }
  }
  EOF
  $ gmcs cdom.cs

The generated code is invalid:

  $ mono cdom.exe
  ...
  public class Resources {
  }
  [assembly: System.CLSCompliantAttribute(false)]

The assembly-level custom attribute MUST precede any type definitions, otherwise a CS1730 is generated.

.NET generates proper code:

  [assembly: System.CLSCompliantAttribute(false)]



  public class Resources {
  }
Comment 1 Marek Safar 2013-07-30 14:19:22 UTC
Fixed in master