Bug 13272 - Indents with mix of tabs and spaces when splitting method argument list over 2 lines
Summary: Indents with mix of tabs and spaces when splitting method argument list over ...
Status: RESOLVED FEATURE
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Linux
: --- normal
Target Milestone: master
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-07-16 12:57 UTC by Gary____
Modified: 2013-07-17 06:55 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FEATURE

Description Gary____ 2013-07-16 12:57:48 UTC
Running master from a month ago or so. When I split the argument list for a method over 2 lines, it will give me tabs up to the indentation point where the first statement started, then spaces over to where the opening bracket of the method is eg.

				bookmark = context.CreateBookmark ("b1", callback, BookmarkOptions.NonBlocking 
				                                   | BookmarkOptions.MultipleResume);


Also, if I convert those spaces to tabs, copy and paste the 2 lines, it will convert them back to spaces again.
Comment 1 Gary____ 2013-07-16 13:01:00 UTC
So that example didn't take well to bugzilla, but it goes something like this

\t\tbookmark = CreateBookmark (param1, param2,  
\t\t         (spaces)          param2, param 3);
Comment 2 Mike Krüger 2013-07-17 01:03:39 UTC
That's like it should be.
Comment 3 Gary____ 2013-07-17 06:11:27 UTC
Fair enough. 

On a different note, is this in-line with mono's coding guidelines as well?

I converted all those spaces to tabs in my project, would it be preferable to change them back to spaces before doing a pull request?
Comment 4 Mike Krüger 2013-07-17 06:55:23 UTC
The problem is that if setting the tabs to a different size the parameters are not aligned anymore
but you've another option to do parameter formatting:

\t\tbookmark = CreateBookmark (
\t\t\tparam1,
\t\t\tparam2,  
\t\t\tparam2,
\t\t\tparam3);


you need to line break after the opening (