Bug 13233 - Overflow in mono_save_seq_point_info
Summary: Overflow in mono_save_seq_point_info
Status: RESOLVED FIXED
Alias: None
Product: Runtime
Classification: Mono
Component: General ()
Version: unspecified
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2013-07-13 15:53 UTC by marc.seebold
Modified: 2013-07-17 23:37 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on GitHub or Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description marc.seebold 2013-07-13 15:53:41 UTC
The following code is problematic (mono/mini/mini.c, @@ -3659,7 +3659,8 @@ mono_save_seq_point_info (MonoCompile *cfg))

info = g_malloc0 (sizeof (MonoSeqPointInfo) + (cfg->seq_points->len - MONO_ZERO_LEN_ARRAY) * sizeof (SeqPoint));

Condition:
cfg->seq_points->len is 0
MONO_ZERO_LEN_ARRAY is not 0

leads to an overflow of (cfg->seq_points->len - MONO_ZERO_LEN_ARRAY).

Solution:
Check size of cfg->seq_points->len.
Comment 1 Zoltan Varga 2013-07-16 17:36:15 UTC
If MONO_ZERO_LEN_ARRAY is not 0, then MonoSeqPointInfo itself contains the first array element.
Comment 2 Zoltan Varga 2013-07-17 23:34:39 UTC
-> NOTABUG.
Comment 3 Zoltan Varga 2013-07-17 23:37:39 UTC
Fixed. Thanks for the report.