Bug 13201 - [VS]We are not able to use option 'Embed Assemblies in native code' when license is Trial on disk
Summary: [VS]We are not able to use option 'Embed Assemblies in native code' when lice...
Status: VERIFIED FIXED
Alias: None
Product: Visual Studio Extensions
Classification: Xamarin
Component: Android ()
Version: unspecified
Hardware: PC Mac OS
: High critical
Target Milestone: ---
Assignee: dean.ellis
URL:
Depends on:
Blocks:
 
Reported: 2013-07-12 06:35 UTC by narayanp
Modified: 2016-08-03 15:22 UTC (History)
6 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
VERIFIED FIXED

Description narayanp 2013-07-12 06:35:25 UTC
Steps to reproduce this issue:
[Condition: License should be Trial on Disk]
1. Open or create android project in VS.
2. Open project Properties.
3. Go to Mono Android Option and try to check option 'Embed assemblies in native code'

Actual Result: Trigger pop up appears which prompts to purchase a license. While on XamarinStudio we are able to check/uncheck this option for Trial license.

Expected Result: If license is trial on disk, user should be able to check/uncheck option 'Embed assemblies in native code' as seeing with XamarinStudio.

Supplement info:
http://screencast.com/t/Be7mYeHtU6

Environment details:
All Windows
VS 2012/2010
Xamarin.Android 4.8.0-1

Regression Status: 
NOT A REGRESSION: This feature was not implemented with previous builds
Comment 1 PJ 2013-07-12 12:12:13 UTC
This is the remaining fix needed for Mkbundle pricing for VS - good to file this separately from XS to keep the work separated, thanks!

Dominique, ( or dean ): Mhutch implemented the logic change in XS to allow Trial to be equal to enterprise, here's the patch: https://github.com/xamarin/md-addins/commit/2099fba9af71869abd1e1ca2cf6b8b20204606e1

This is what we need in VS
Comment 2 PJ 2013-07-12 16:23:26 UTC
dominique
pjbeaman, I believe dellis^ worked on that, or was assigned it in the last meeting. So this is a regression on that implementation?
pjbeaman
No, this was a hole in the implementation that was fixed on the XS side after a meeting and discussion, here's the link: https://bugzilla.xamarin.com/show_bug.cgi?id=13064
pjbeaman
The problem was that you were not activated with trial over the business, so you keep being given the activation pop up
pjbeaman
Lewing fixed half of the issue on the server, but the IDE required a change as well
pjbeaman
dominique: I don't want to add this worry while it's 10pm on a friday
pjbeaman
but I wanted to make sure it wasn't missed
Comment 3 PJ 2013-07-12 16:24:04 UTC
ASSIGNing to Dean so he can take a look after the weekend.
Comment 4 dean.ellis 2013-07-15 11:40:02 UTC
Fixed in mtvs-1.3-series/d057a0a56e
Comment 5 Saurabh 2013-07-15 14:15:15 UTC
We have checked this issue with 'X.Android 4.8.00004' and we are still getting same issue. We are still not able to use option 'Embed Assemblies in native code' with trial license, it prompts for Enterprise license.

Screencast: http://screencast.com/t/RkRaRk25BsY3

Hence, we are reopening this issue against X.Android.
Comment 6 PJ 2013-07-15 14:33:57 UTC
He just fixed it 2.5 hours ago, and no new test build has been distributed since. Please verify with the next test build > 4.8.0.4
Comment 7 narayanp 2013-07-16 11:04:44 UTC
Today I have checked this issue on following builds

All Windows
VS 2012/2010
Xamarin.Android 4.8.0-7

When License is trial on disk, User can check/uncheck option 'Bundle assemblies in native code'. This is the screencast for the same: http://screencast.com/t/PIJLyDupxcCw

Changing the status to Verified.