Bug 13160 - Undo command should undo Source Analysis actions
Summary: Undo command should undo Source Analysis actions
Status: RESOLVED NOT_REPRODUCIBLE
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Text Editor ()
Version: 4.0.9
Hardware: PC Windows
: --- normal
Target Milestone: master
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-07-10 15:46 UTC by Jeffrey Stedfast
Modified: 2016-10-21 02:31 UTC (History)
3 users (show)

Tags:
Is this bug a regression?: ---
Last known good build:


Attachments
Demonstration of incorrect undo behaviour (628.15 KB, video/avi)
2013-07-10 19:48 UTC, Ashley
Details


Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED NOT_REPRODUCIBLE

Description Jeffrey Stedfast 2013-07-10 15:46:04 UTC
From a customer:

Also, after you've accepted one of it's suggestions, Ctrl+Z does not undo it. It pretends that modification never even happened, and undoes the last thing you did before that instead.
Comment 1 Mike Krüger 2013-07-10 16:04:10 UTC
Works for me - a bit more context would've been nice. In fact the text editor isn't able to 'skip' text operations.
Comment 2 Ashley 2013-07-10 19:46:52 UTC
I could reproduce this reliably in Xamarin Studio 4.0.8, using the 'make method static' suggestion. I have captured a video of my screen doing this.

After upgrading to 4.0.9, I can't seem to make the 'make method static' suggestion appear, so cannot test if the issue still exists. Is there a way to trigger this suggestion?
Comment 3 Ashley 2013-07-10 19:48:32 UTC
Created attachment 4312 [details]
Demonstration of incorrect undo behaviour
Comment 4 Mike Krüger 2013-07-11 02:22:50 UTC
Thats a 'convert to static' method issue bug. I disabled that in master a while ago because it doesn't work.

Other issues shouldn't have that problem. But I need to figure out why it does that - it looks like it duplicates the document and does it's operation on the copy.