Bug 119 - Data nodes in MSBuild files have excessive nesting
Summary: Data nodes in MSBuild files have excessive nesting
Status: RESOLVED NOT_ON_ROADMAP
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: Project Model ()
Version: Trunk
Hardware: PC Windows
: Low normal
Target Milestone: ---
Assignee: Bugzilla
URL:
Depends on:
Blocks:
 
Reported: 2011-07-30 18:39 UTC by Mikayla Hutchinson [MSFT]
Modified: 2015-09-25 13:04 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED NOT_ON_ROADMAP

Description Mikayla Hutchinson [MSFT] 2011-07-30 18:39:47 UTC
Data nodes in MSBuild files have excessive nesting, for example


<CustomCommands>
  <CustomCommands>
    <Command type="Execute" command="../foo.exe" />
  </CustomCommands>
</CustomCommands>

This is because MSBuildProjectHandler is using GetXmlString/GetDataNode, which which consider the node to have an outer XML element, and then put that in a property of the same name.

On a related note, this isn't really a good way to handle custom commands. Firstly, properties aren't expected to have XML content. Secondly, it won't work with xbuild. Thirdly, it could conflict with future MS additions. A better solution would be to handle them as MSBuild targets, using the MS extension points.
Comment 1 Lluis Sanchez 2015-09-25 13:04:53 UTC
We are moving away from this model, but we need to keep this double nesting for backwards compatibility.