Bug 11856 - Should be a Code Issue in case of duplicate logical expressions
Summary: Should be a Code Issue in case of duplicate logical expressions
Status: RESOLVED FIXED
Alias: None
Product: Xamarin Studio
Classification: Desktop
Component: C# Binding ()
Version: Trunk
Hardware: PC Windows
: --- normal
Target Milestone: ---
Assignee: Mike Krüger
URL:
Depends on:
Blocks:
 
Reported: 2013-04-18 16:53 UTC by Ciprian Khlud
Modified: 2013-05-02 05:54 UTC (History)
1 user (show)

Tags:
Is this bug a regression?: ---
Last known good build:

Notice (2018-05-24): bugzilla.xamarin.com is now in read-only mode.

Please join us on Visual Studio Developer Community and in the Xamarin and Mono organizations on GitHub to continue tracking issues. Bugzilla will remain available for reference in read-only mode. We will continue to work on open Bugzilla bugs, copy them to the new locations as needed for follow-up, and add the new items under Related Links.

Our sincere thanks to everyone who has contributed on this bug tracker over the years. Thanks also for your understanding as we make these adjustments and improvements for the future.


Please create a new report on Developer Community or GitHub with your current version information, steps to reproduce, and relevant error messages or log files if you are hitting an issue that looks similar to this resolved bug and you do not yet see a matching new report.

Related Links:
Status:
RESOLVED FIXED

Description Ciprian Khlud 2013-04-18 16:53:16 UTC
Duplicating expressions in if, while, and in boolean conditions are a sign of copy/paste in code.

So there should be a code issue that will detect if there is a sequence of expressions (of minimum 2, but it should work with as many are using the same operator) and if they repeat and are the same, they should be both underlined (or one of them) and notice that there is a duplication.

sample code that happen:
if( test(Point.X) && test (Point.Y) && test(Point.X)) 
is most likely that the devel wanted to put Point.Z, but he "missed" to replace the X with Z.
The operators: && and || should be checked and the expressions that are compared should be tested on their entire depth.
Comment 2 Mike Krüger 2013-05-02 05:54:43 UTC
Thanks